Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle mis-sized structs in XARCH PUTARG_STK codegen #68611

Merged
merged 2 commits into from
Jun 13, 2022
Merged

Handle mis-sized structs in XARCH PUTARG_STK codegen #68611

merged 2 commits into from
Jun 13, 2022

Commits on Jun 13, 2022

  1. Handle "mis-sized" structs in XARCH PUTARG_STK codegen 

    Previously, for structs which were not a multiple of TARGET_POINTER_SIZE
in size:

1) On x86, we copied them to a local in morph. This was a small CQ issue.
2) On Unix x64, we didn't handle them at all and could read out of bounds
   in "genStructPutArgUnroll".

This change fixes both issues by properly detecting cases where we need to
be careful and updating codegen to use correct load sizes.
    @SingleAccretion
    SingleAccretion committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    0203ee2 View commit details
    Browse the repository at this point in the history

  2. Add a test

    @SingleAccretion
    SingleAccretion committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    14b4d6c View commit details
    Browse the repository at this point in the history