Merging internal commits for release/6.0

[vseanreesermsft]

No description provided.

[ghost]

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

---

null

Author:	vseanreesermsft
Assignees:	vseanreesermsft
Labels:	area-System.Net
Milestone:	-

[carlossanlop]

@vseanreesermsft I assume this is all scripted so it's not weird that all the commits have the same name, and the end result is fewer changed files than the total files changes by all the commits. Correct?

I ask because your other internal merge PRs have unique names in the commits.

[ghost]

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

---

null

Author:	vseanreesermsft
Assignees:	vseanreesermsft
Labels:	area-Infrastructure
Milestone:	-

[carlossanlop]

I'll open issues for the failures:

• Libraries Test Run release coreclr windows x64 Debug

SSL test throws "unstable on Windows 11"

System.Net.Security.Tests.LoggingTest.EventSource_EventsRaisedAsExpected [FAIL]
    Microsoft.DotNet.RemoteExecutor.RemoteExecutionException : Remote process failed with an unhandled exception.
    Stack Trace:
      
      Child exception:
        Microsoft.DotNet.XUnitExtensions.SkipTestException: Unstable on Windows 11
      /_/src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamStreamToStreamTest.cs(79,0): at System.Net.Security.Tests.SslStreamStreamToStreamTest.SslStream_StreamToStream_Authentication_Success(X509Certificate serverCert, X509Certificate clientCert)
      /_/src/libraries/System.Net.Security/tests/FunctionalTests/LoggingTest.cs(45,0): at System.Net.Security.Tests.LoggingTest.<>c.<EventSource_EventsRaisedAsExpected>b__1_1()
      /_/src/libraries/Common/tests/System/Diagnostics/Tracing/TestEventListener.cs(111,0): at System.Diagnostics.Tracing.TestEventListener.RunWithCallback(Action`1 handler, Action body)
      /_/src/libraries/System.Net.Security/tests/FunctionalTests/LoggingTest.cs(41,0): at System.Net.Security.Tests.LoggingTest.<>c.<EventSource_EventsRaisedAsExpected>b__1_0()

• Libraries Test Run release coreclr windows x86 Debug

Timeout in System.Text.Json

----- start Tue Apr 12 20:48:33 UTC 2022 =============== To repro directly: =====================================================
pushd .
/root/helix/work/correlation/dotnet exec --runtimeconfig System.Text.Json.Tests.runtimeconfig.json --depsfile System.Text.Json.Tests.deps.json xunit.console.dll System.Text.Json.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing 
popd
===========================================================================================================
/root/helix/work/workitem/e /root/helix/work/workitem/e
Discovering: System.Text.Json.Tests (method display = ClassAndMethod, method display options = None)
Discovered:  System.Text.Json.Tests (found 2791 of 2838 test cases)
Starting:    System.Text.Json.Tests (parallel test collections = on, max threads = 2)

...
[EXECUTION TIMED OUT]
Exit Code:-3Executor timed out after 900 seconds and was killed
['System.Text.Json.Tests' END OF WORK ITEM LOG: Command timed out, and was killed]

And a bunch of authentication failures

System.Net.Security.Tests.LoggingTest.EventSource_EventsRaisedAsExpected [FAIL]
    Microsoft.DotNet.RemoteExecutor.RemoteExecutionException : Remote process failed with an unhandled exception.
    Stack Trace:
      
      Child exception:
        Microsoft.DotNet.XUnitExtensions.SkipTestException: Unstable on Windows 11
      /_/src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamStreamToStreamTest.cs(79,0): at System.Net.Security.Tests.SslStreamStreamToStreamTest.SslStream_StreamToStream_Authentication_Success(X509Certificate serverCert, X509Certificate clientCert)
      /_/src/libraries/System.Net.Security/tests/FunctionalTests/LoggingTest.cs(45,0): at System.Net.Security.Tests.LoggingTest.<>c.<EventSource_EventsRaisedAsExpected>b__1_1()
      /_/src/libraries/Common/tests/System/Diagnostics/Tracing/TestEventListener.cs(111,0): at System.Diagnostics.Tracing.TestEventListener.RunWithCallback(Action`1 handler, Action body)
      /_/src/libraries/System.Net.Security/tests/FunctionalTests/LoggingTest.cs(41,0): at System.Net.Security.Tests.LoggingTest.<>c.<EventSource_EventsRaisedAsExpected>b__1_0()
      
      Child process:
        System.Net.Security.Tests, Version=6.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51 System.Net.Security.Tests.LoggingTest+<>c Void <EventSource_EventsRaisedAsExpected>b__1_0()

System.Net.Security.Tests.ApmSslStreamSystemDefaultTest.ClientAndServer_OneOrBothUseDefault_Ok(clientProtocols: null, serverProtocols: Tls12) [FAIL]
    System.AggregateException : One or more errors occurred. (One or more errors occurred. (Authentication failed, see inner exception.)) (One or more errors occurred. (Authentication failed, see inner exception.))
    ---- System.AggregateException : One or more errors occurred. (Authentication failed, see inner exception.)
    -------- System.Security.Authentication.AuthenticationException : Authentication failed, see inner exception.
    ------------ System.ComponentModel.Win32Exception : The function requested is not supported
    ---- System.AggregateException : One or more errors occurred. (Authentication failed, see inner exception.)
    -------- System.Security.Authentication.AuthenticationException : Authentication failed, see inner exception.
    ------------ System.ComponentModel.Win32Exception : The client and server cannot communicate, because they do not possess a common algorithm.
    Stack Trace:
      /_/src/libraries/Common/tests/System/Threading/Tasks/TaskTimeoutExtensions.cs(89,0): at System.Threading.Tasks.TaskTimeoutExtensions.WhenAllOrAnyFailed(Task[] tasks)
      /_/src/libraries/Common/tests/System/Threading/Tasks/TaskTimeoutExtensions.cs(55,0): at System.Threading.Tasks.TaskTimeoutExtensions.WhenAllOrAnyFailed(Task[] tasks, Int32 millisecondsTimeout)
      /_/src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamSystemDefaultsTest.cs(92,0): at System.Net.Security.Tests.SslStreamSystemDefaultTest.ClientAndServer_OneOrBothUseDefault_Ok(Nullable`1 clientProtocols, Nullable`1 serverProtocols)
      --- End of stack trace from previous location ---
      ----- Inner Stack Trace #1 (System.AggregateException) -----
      
      ----- Inner Stack Trace -----
      /_/src/libraries/System.Net.Security/src/System/Net/Security/SslStream.Implementation.cs(418,0): at System.Net.Security.SslStream.ForceAuthenticationAsync[TIOAdapter](TIOAdapter adapter, Boolean receiveFirst, Byte[] reAuthenticationData, Boolean isApm)
      /_/src/libraries/Common/src/System/Threading/Tasks/TaskToApm.cs(41,0): at System.Threading.Tasks.TaskToApm.End(IAsyncResult asyncResult)
      /_/src/libraries/System.Net.Security/src/System/Net/Security/SslStream.cs(211,0): at System.Net.Security.SslStream.EndAuthenticateAsClient(IAsyncResult asyncResult)
      /_/src/libraries/System.Private.CoreLib/src/System/Threading/Tasks/FutureFactory.cs(544,0): at System.Threading.Tasks.TaskFactory`1.FromAsyncCoreLogic(IAsyncResult iar, Func`2 endFunction, Action`1 endAction, Task`1 promise, Boolean requiresSynchronization)
      --- End of stack trace from previous location ---
      /_/src/libraries/Common/tests/System/Threading/Tasks/TaskTimeoutExtensions.cs(72,0): at System.Threading.Tasks.TaskTimeoutExtensions.WhenAllOrAnyFailed(Task[] tasks)
      ----- Inner Stack Trace -----
      
      ----- Inner Stack Trace #2 (System.AggregateException) -----
      
      ----- Inner Stack Trace -----
      /_/src/libraries/System.Net.Security/src/System/Net/Security/SslStream.Implementation.cs(418,0): at System.Net.Security.SslStream.ForceAuthenticationAsync[TIOAdapter](TIOAdapter adapter, Boolean receiveFirst, Byte[] reAuthenticationData, Boolean isApm)
      /_/src/libraries/Common/src/System/Threading/Tasks/TaskToApm.cs(41,0): at System.Threading.Tasks.TaskToApm.End(IAsyncResult asyncResult)
      /_/src/libraries/System.Net.Security/src/System/Net/Security/SslStream.cs(250,0): at System.Net.Security.SslStream.EndAuthenticateAsServer(IAsyncResult asyncResult)
      /_/src/libraries/System.Private.CoreLib/src/System/Threading/Tasks/FutureFactory.cs(544,0): at System.Threading.Tasks.TaskFactory`1.FromAsyncCoreLogic(IAsyncResult iar, Func`2 endFunction, Action`1 endAction, Task`1 promise, Boolean requiresSynchronization)
      --- End of stack trace from previous location ---
      /_/src/libraries/Common/tests/System/Threading/Tasks/TaskTimeoutExtensions.cs(64,0): at System.Threading.Tasks.TaskTimeoutExtensions.WhenAllOrAnyFailed(Task[] tasks)
      ----- Inner Stack Trace -----

System.Net.Security.Tests.SslStreamTls11NetworkConformanceTests.ZeroByteWrite_OtherDataReceivedSuccessfully(mode: SyncArray) [FAIL]
    System.ComponentModel.Win32Exception : The client and server cannot communicate, because they do not possess a common algorithm.
    Stack Trace:
      /_/src/libraries/Common/src/Interop/Windows/SspiCli/SSPIWrapper.cs(138,0): at System.Net.SSPIWrapper.AcquireCredentialsHandle(ISSPIInterface secModule, String package, CredentialUse intent, SCH_CREDENTIALS* scc)
      /_/src/libraries/System.Net.Security/src/System/Net/Security/SslStreamPal.Windows.cs(574,0): at System.Net.Security.SslStreamPal.AcquireCredentialsHandle(CredentialUse credUsage, SCH_CREDENTIALS* secureCredential)
      /_/src/libraries/System.Net.Security/src/System/Net/Security/SslStreamPal.Windows.cs(276,0): at System.Net.Security.SslStreamPal.AcquireCredentialsHandleSchCredentials(SslStreamCertificateContext certificateContext, SslProtocols protocols, EncryptionPolicy policy, Boolean isServer)
      /_/src/libraries/System.Net.Security/src/System/Net/Security/SslStreamPal.Windows.cs(126,0): at System.Net.Security.SslStreamPal.AcquireCredentialsHandle(SslStreamCertificateContext certificateContext, SslProtocols protocols, EncryptionPolicy policy, Boolean isServer)
      /_/src/libraries/System.Net.Security/src/System/Net/Security/SecureChannel.cs(606,0): at System.Net.Security.SecureChannel.AcquireClientCredentials(Byte[]& thumbPrint)
      /_/src/libraries/System.Net.Security/src/System/Net/Security/SecureChannel.cs(782,0): at System.Net.Security.SecureChannel.GenerateToken(ReadOnlySpan`1 inputBuffer, Byte[]& output)
      /_/src/libraries/System.Net.Security/src/System/Net/Security/SecureChannel.cs(725,0): at System.Net.Security.SecureChannel.NextMessage(ReadOnlySpan`1 incomingBuffer)
      /_/src/libraries/System.Net.Security/src/System/Net/Security/SslStream.Implementation.cs(352,0): at System.Net.Security.SslStream.ForceAuthenticationAsync[TIOAdapter](TIOAdapter adapter, Boolean receiveFirst, Byte[] reAuthenticationData, Boolean isApm)
      /_/src/libraries/Common/tests/System/Threading/Tasks/TaskTimeoutExtensions.cs(64,0): at System.Threading.Tasks.TaskTimeoutExtensions.WhenAllOrAnyFailed(Task[] tasks)
      /_/src/libraries/Common/tests/System/Threading/Tasks/TaskTimeoutExtensions.cs(91,0): at System.Threading.Tasks.TaskTimeoutExtensions.WhenAllOrAnyFailed(Task[] tasks)
      /_/src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamConformanceTests.cs(28,0): at System.Net.Security.Tests.SslStreamConformanceTests.CreateWrappedConnectedStreamsAsync(StreamPair wrapped, Boolean leaveOpen)
      /_/src/libraries/Common/tests/StreamConformanceTests/System/IO/StreamConformanceTests.cs(2251,0): at System.IO.Tests.ConnectedStreamConformanceTests.ZeroByteWrite_OtherDataReceivedSuccessfully(ReadWriteMode mode)
      --- End of stack trace from previous location ---
  System.Net.Security.Tests.ServerNoEncryptionTest.ServerNoEncryption_ClientAllowNoEncryption_ConnectWithNoEncryption [FAIL]
    System.Security.Authentication.AuthenticationException : Authentication failed, see inner exception.
    ---- System.ComponentModel.Win32Exception : The function requested is not supported
    Stack Trace:
      /_/src/libraries/System.Net.Security/src/System/Net/Security/SslStream.Implementation.cs(418,0): at System.Net.Security.SslStream.ForceAuthenticationAsync[TIOAdapter](TIOAdapter adapter, Boolean receiveFirst, Byte[] reAuthenticationData, Boolean isApm)
      /_/src/libraries/System.Net.Security/tests/FunctionalTests/ServerNoEncryptionTest.cs(62,0): at System.Net.Security.Tests.ServerNoEncryptionTest.ServerNoEncryption_ClientAllowNoEncryption_ConnectWithNoEncryption()
      --- End of stack trace from previous location ---
      ----- Inner Stack Trace -----

  System.Net.Security.Tests.ServerNoEncryptionTest.ServerNoEncryption_ClientNoEncryption_ConnectWithNoEncryption [FAIL]
    System.Security.Authentication.AuthenticationException : Authentication failed, see inner exception.
    ---- System.ComponentModel.Win32Exception : The client and server cannot communicate, because they do not possess a common algorithm.
    Stack Trace:
      /_/src/libraries/System.Net.Security/src/System/Net/Security/SslStream.Implementation.cs(364,0): at System.Net.Security.SslStream.ForceAuthenticationAsync[TIOAdapter](TIOAdapter adapter, Boolean receiveFirst, Byte[] reAuthenticationData, Boolean isApm)
      /_/src/libraries/System.Net.Security/tests/FunctionalTests/ServerNoEncryptionTest.cs(88,0): at System.Net.Security.Tests.ServerNoEncryptionTest.ServerNoEncryption_ClientNoEncryption_ConnectWithNoEncryption()
      --- End of stack trace from previous location ---
      ----- Inner Stack Trace -----

  System.Net.Security.Tests.ClientAsyncAuthenticateTest.ClientAsyncAuthenticate_IndividualServerVsAllClientSupportedProtocols_Success(serverProtocol: Tls) [FAIL]
    System.IO.IOException :  Received an unexpected EOF or 0 bytes from the transport stream.
    Stack Trace:
      /_/src/libraries/System.Net.Security/src/System/Net/Security/SslStream.Implementation.cs(1102,0): at System.Net.Security.SslStream.<FillHandshakeBufferAsync>g__InternalFillHandshakeBufferAsync|187_0[TIOAdapter](TIOAdapter adap, ValueTask`1 task, Int32 minSize)
      /_/src/libraries/System.Net.Security/src/System/Net/Security/SslStream.Implementation.cs(462,0): at System.Net.Security.SslStream.ReceiveBlobAsync[TIOAdapter](TIOAdapter adapter)
      /_/src/libraries/System.Net.Security/src/System/Net/Security/SslStream.Implementation.cs(381,0): at System.Net.Security.SslStream.ForceAuthenticationAsync[TIOAdapter](TIOAdapter adapter, Boolean receiveFirst, Byte[] reAuthenticationData, Boolean isApm)
      /_/src/libraries/System.Net.Security/tests/FunctionalTests/ClientAsyncAuthenticateTest.cs(155,0): at System.Net.Security.Tests.ClientAsyncAuthenticateTest.ClientAsyncSslHelper(EncryptionPolicy encryptionPolicy, SslProtocols clientSslProtocols, SslProtocols serverSslProtocols, RemoteCertificateValidationCallback certificateCallback)
      /_/src/libraries/System.Net.Security/tests/FunctionalTests/ClientAsyncAuthenticateTest.cs(102,0): at System.Net.Security.Tests.ClientAsyncAuthenticateTest.ClientAsyncAuthenticate_IndividualServerVsAllClientSupportedProtocols_Success(SslProtocols serverProtocol)
      --- End of stack trace from previous location ---

[danmoseley]

In the first one, we should skip not fail. RemoteExecutor does not know what to do with SkipTestExecution. Ideally it could catch it and "tunnel" it through to rethrow in the parent -- would be a bug in dotnet/arcade. Or, we should never throw it within the code running remotely - a test bug.