Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Group 8] Enable nullable annotations for Microsoft.Extensions.Hosting #67511

Merged
merged 9 commits into from
Apr 16, 2022
Merged

[Group 8] Enable nullable annotations for Microsoft.Extensions.Hosting #67511

merged 9 commits into from
Apr 16, 2022

Conversation

maxkoshevoi
Copy link
Contributor

Related to #43605

image

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Apr 3, 2022
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Apr 3, 2022

Tagging subscribers to this area: @dotnet/area-extensions-hosting
See info in area-owners.md if you want to be subscribed.

Issue Details

Related to #43605

image

Author: maxkoshevoi
Assignees: -
Labels:

new-api-needs-documentation, area-Extensions-Hosting, community-contribution
Milestone: -

@eerhardt
Copy link
Member

eerhardt commented Apr 4, 2022 •
edited
Loading

#nullable enable

Can you remove these #nullable enable lines?

In reply to: 1088038225

Refers to: src/libraries/Microsoft.Extensions.Hosting/src/Host.cs:59 in 981b97b. [](commit_id = 981b97b, deletion_comment = False)

@eerhardt
Copy link
Member

eerhardt commented Apr 4, 2022 •
edited
Loading

#nullable enable

Same here. Please remove.

In reply to: 1088038409

Refers to: src/libraries/Microsoft.Extensions.Hosting/src/HostApplicationBuilder.cs:4 in 981b97b. [](commit_id = 981b97b, deletion_comment = False)

@maxkoshevoi maxkoshevoi marked this pull request as ready for review April 8, 2022 09:00
This was referenced Apr 8, 2022
Closed
Closed
eerhardt
eerhardt approved these changes Apr 15, 2022
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just 2 small libraries to go after this one!

@eerhardt eerhardt merged commit a4f0bfc into dotnet:main Apr 16, 2022
@maxkoshevoi maxkoshevoi deleted the mk/43605-hosting branch April 16, 2022 05:41
@ghost ghost locked as resolved and limited conversation to collaborators May 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gfoidl gfoidl gfoidl left review comments

@eerhardt eerhardt eerhardt approved these changes

Assignees
No one assigned
Labels
area-Extensions-Hosting community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxkoshevoi @eerhardt @gfoidl