Fix jit attach hang at Shutdown #67166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#66715 We are seeing exceptions thrown at shutdown turn into hangs because the debugger lock suspends threads at that point. We are mitigating that problem by disabling the jit attach setup work and allowing WatsonLastChance to continue.
|
Tagging subscribers to this area: @tommcdon Issue DetailsFixes #66715 We are seeing exceptions thrown at shutdown turn into hangs because the debugger @dotnet/dotnet-diag
|
mikem8361
approved these changes
Mar 25, 2022
|
Trying on my repro case.. |
|
I can confirm that my repro case now exits (with an AV, but it exits!) |
radekdoulik
pushed a commit
to radekdoulik/runtime
that referenced
this pull request
Mar 30, 2022
Fixes dotnet#66715 We are seeing exceptions thrown at shutdown turn into hangs because the debugger lock suspends threads at that point. We are mitigating that problem by disabling the jit attach setup work and allowing WatsonLastChance to continue.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66715
We are seeing exceptions thrown at shutdown turn into hangs because the debugger
lock suspends threads at that point. We are mitigating that problem by disabling the
jit attach setup work and allowing WatsonLastChance to continue.
@dotnet/dotnet-diag