Fix nullable annotations in EventSourceLogger
#67065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-extensions-logging Issue DetailsFix issue introduced in #66802 since CI wasn't rerun after #66960 was merged. @eerhardt could you please merge this asap? From my post of view right now all CI runs for this repo would fail
|
maxkoshevoi
changed the title
EventSourceLogger
stephentoub
approved these changes
Mar 23, 2022
|
Merging to fix build break |
eerhardt
reviewed
Mar 23, 2022
There was a problem hiding this comment.
Thanks @maxkoshevoi and @stephentoub. Sorry I didn't catch this conflict myself before merging.
radekdoulik
pushed a commit
to radekdoulik/runtime
that referenced
this pull request
Mar 30, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue introduced in #66802 since CI wasn't rerun after #66960 was merged.
@eerhardt could you please merge this asap? From my point of view right now all CI runs for this repo would fail