Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use values from TlsCipherSuiteData for SslConnectionInfo on Windows #66702

Closed
wants to merge 2 commits into from
Closed

Use values from TlsCipherSuiteData for SslConnectionInfo on Windows #66702

wants to merge 2 commits into from

Conversation

rzikm
Copy link
Member

@rzikm rzikm commented Mar 16, 2022 •
edited
Loading

Contributes to #37578

On Windows, the value returned from SChannel for the key exchange algorithm type cannot be mapped 1:1 to the ExchangeAlgorithmType enum. This PR makes SslConnectionInfo be retrieved from TlsCipherSuiteData like on Unix platforms for consistency.

@ghost ghost assigned rzikm Mar 16, 2022
@ghost
Copy link

ghost commented Mar 16, 2022

Tagging subscribers to this area: @dotnet/ncl, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #37578

On Windows, the value returned from SChannel for the key exchange algorithm type cannot be mapped 1:1 to the ExchangeAlgorithmType enum. This PR unifies makes SslConnectionInfo to retrieved from TlsCipherSuiteData like on Unix platforms for consistency.

Author: rzikm
Assignees: rzikm
Labels:

area-System.Net.Security
Milestone: -

@rzikm
Copy link
Member Author

rzikm commented Mar 16, 2022

This should also close #55570

krwq
krwq reviewed Mar 16, 2022
View reviewed changes
src/libraries/System.Net.Security/src/System.Net.Security.csproj
Comment on lines -116 to -122
<ItemGroup Condition="'$(TargetPlatformIdentifier)' == 'windows'">
<None Include="System\Net\Security\TlsCipherSuiteData.Lookup.cs">
<DesignTime>True</DesignTime>
<AutoGen>True</AutoGen>
<DependentUpon>TlsCipherSuiteData.Lookup.tt</DependentUpon>
</None>
</ItemGroup>
Copy link
Member

@krwq krwq Mar 16, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider preserving

<AutoGen>True</AutoGen>
<DependentUpon>TlsCipherSuiteData.Lookup.tt</DependentUpon>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that should be preserved in the ItemGroup above (I removed the part of the condition that excludes Windows there)

@krwq krwq requested a review from bartonjs March 16, 2022 12:02
This was referenced Mar 16, 2022
Closed
Closed
@bartonjs
Copy link
Member

I think that this should be blocked behind #55570 (un-collapsing ECDH/FFDH). Or they could be done together.

@runfoapp runfoapp bot mentioned this pull request Mar 18, 2022
Closed
@rzikm
Copy link
Member Author

rzikm commented Mar 25, 2022

very well then, closing for now.

@rzikm rzikm closed this Mar 25, 2022
@karelz karelz added this to the 7.0.0 milestone Apr 8, 2022
@ghost ghost locked as resolved and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@krwq krwq krwq left review comments

@bartonjs bartonjs Awaiting requested review from bartonjs

Assignees

@rzikm rzikm

Labels
area-System.Net.Security
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@rzikm @bartonjs @krwq @karelz