Count OBJ/BLK as memory uses
#66135
Merged
Count OBJ/BLK as memory uses
#66135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to count OBJ/BLK as uses, otherwise SSA can fail to insert a memory PHI where one is needed.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsOtherwise SSA can fail to insert a memory PHI where one is needed. We're expecting diff in one test where I noticed this while rewriting liveness to stop relying on location nodes.
|
|
Will assume the timeouts are not related, this is a one-diff change that only makes us more correct/pessimistic. |
|
@dotnet/jit-contrib |
jakobbotsch
approved these changes
Mar 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise SSA can fail to insert a memory PHI where one is needed.
We're expecting diff in one test where I noticed this while rewriting liveness to stop relying on location nodes.