-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve SslStream tests on misconfigured systems #64966
Conversation
Tagging subscribers to this area: @dotnet/ncl, @vcsjones Issue Detailsfixes #64943 The most problematic are tests expecting failures. However since we fail to even send something in many cases we basically wait 4 minutes for each failing test. This change has two parts: It drops PassingTestTimeoutMilliseconds to 1 minute. Since we generally use it to time box single SSL it is still plenty but still much less than original value. With this failed runs takes ~ 7 minutes and it should finish in CI. Better platform detection and failure avoidance comes from #64923. cc: @safern we should take this to 6.0 if we ever back-port the 2022 queue.
|
src/libraries/System.Net.Security/tests/FunctionalTests/ServerAsyncAuthenticateTest.cs
Outdated
Show resolved
Hide resolved
Failing macOS tests are #64963 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We already did. So maybe we should get the backport going. |
/backport to release/6.0 |
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1814810434 |
sounds good @safern. There is more. I'll initiate the backports as they get into main to stabilize the S2022 runs. |
all the test failures looks like infrastructure issues. |
fixes #64943
I did not any real hangs. But since LOT of tests failing, the run takes very long time ~ 17 minutes on my repro machine.
The most problematic are tests expecting failures. However since we fail to even send something in many cases we basically wait 4 minutes for each failing test.
This change has two parts:
When we expect failure, ignore only Authentication exceptions. That will raise
Win32Exception
and fail the test in cases we even fail so send something.It drops PassingTestTimeoutMilliseconds to 1 minute. Since we generally use it to time box single SSL it is still plenty but still much less than original value.
With this failed runs takes ~ 7 minutes and it should finish in CI.
Better platform detection and failure avoidance comes from #64923.
cc: @safern we should take this to 6.0 if we ever back-port the 2022 queue.