Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable InspectVariableBeforeAndAfterAssignment test #64546

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Disable InspectVariableBeforeAndAfterAssignment test #64546

merged 1 commit into from
Jan 31, 2022

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented Jan 31, 2022

This wasm debugger test has been causing frequent failures in the rolling build. See #64188 for details.

@sbomer
Disable InspectVariableBeforeAndAfterAssignment test
6057a86 
This wasm debugger test has been causing frequent failures in the rolling build.
@ghost ghost assigned sbomer Jan 31, 2022
@ghost
Copy link

ghost commented Jan 31, 2022

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

This wasm debugger test has been causing frequent failures in the rolling build. See #64188 for details.

Author: sbomer
Assignees: sbomer
Labels:

area-Debugger-mono
Milestone: -

@sbomer sbomer merged commit 09f681f into dotnet:main Jan 31, 2022
@radical
Copy link
Member

radical commented Jan 31, 2022

Just curious - why was this needed after #64503 ?

@radical
Copy link
Member

radical commented Jan 31, 2022

Also, this breaks the tests:

 Build Browser wasm windows Release Mono_DebuggerTests / Build product
❌[Log] src\mono\wasm\debugger\DebuggerTestSuite\AssignmentTests.cs(41,10): error CS0246: The type or namespace name 'ActiveIssueAttribute' could not be found (are you missing a using directive or an assembly reference?)
❌[Log] src\mono\wasm\debugger\DebuggerTestSuite\AssignmentTests.cs(41,10): error CS0246: The type or namespace name 'ActiveIssue' could not be found (are you missing a using directive or an assembly reference?)

radical added a commit to radical/runtime that referenced this pull request Jan 31, 2022
@radical
Revert "Disable InspectVariableBeforeAndAfterAssignment test (dotnet#…
5b61460 
…64546)"

This reverts commit 09f681f.

This isn't needed as the tests are being run only in `runtime-staging`
now. And this commit itself doesn't build.
@sbomer
Copy link
Member Author

sbomer commented Jan 31, 2022

@radical, sorry, I didn't realize that this was part of the same test suite you moved to the staging pipeline. Thanks for reverting it.

@radical
Copy link
Member

radical commented Jan 31, 2022

No problem 👍

radical added a commit that referenced this pull request Feb 1, 2022
@radical
[wasm] Revert "Disable InspectVariableBeforeAndAfterAssignment test (#…
4466525 
…64546)" (#64574)

This reverts commit 09f681f.

This isn't needed as the tests are being run only in `runtime-staging`
now. And this commit itself doesn't build.
@ghost ghost locked as resolved and limited conversation to collaborators Mar 3, 2022
@sbomer sbomer deleted the disableDebuggerAssignmentTest branch November 3, 2023 18:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

@thaystg thaystg Awaiting requested review from thaystg

Assignees

@sbomer sbomer

Labels
area-Debugger-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbomer @radical @AaronRobinsonMSFT