Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the varargs-based mdarray helper. #62855

Merged
merged 8 commits into from
Dec 16, 2021

Conversation

jkoritzinsky
Copy link
Member

Rename the non-varargs helper to the old name of the varargs helper as it has a better name.

Remove some now-unused varargs-specific macros.

Fixes #62747

Reviewing without whitespace changes is recommended for the changes in the JIT.

Rename the nonvarargs one to the old name of the varargs-based helper as it has the better name.
@jkoritzinsky
Copy link
Member Author

/azp run runtime-coreclr crossgen2 outerloop

@dotnet dotnet deleted a comment from azure-pipelines bot Dec 15, 2021
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@VSadov
Copy link
Member

VSadov commented Dec 15, 2021

I think the change should also re-enable TestGenericMDArrayBehavior test on OSX

@jkoritzinsky
Copy link
Member Author

Linux_musl ARM test failure is #62873 (I made the criterion for the tracking issue too fine-grained and missed the musl instances of the failure)

Copy link
Member

@VSadov VSadov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!!!

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkoritzinsky jkoritzinsky merged commit 562d1e7 into dotnet:main Dec 16, 2021
@jkoritzinsky jkoritzinsky deleted the mdarr-no-vararg branch December 16, 2021 23:11
@ghost ghost locked as resolved and limited conversation to collaborators Jan 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Constructing MD arrays in R2R code does not work on OSX/ARM64
4 participants