Skip to content

Put generated InvalidClientHelloDataTruncatedBytes data into one test #62480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Put generated InvalidClientHelloDataTruncatedBytes data into one test #62480

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/libraries/System.Net.Security/tests/FunctionalTests/TlsFrameHelperTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,14 @@ public void SniHelper_InvalidData_Fails(int id, byte[] clientHello)
InvalidClientHello(clientHello, id, shouldPass: false);
}

[Theory]
[MemberData(nameof(InvalidClientHelloDataTruncatedBytes))]
public void SniHelper_TruncatedData_Fails(int id, byte[] clientHello)
[Fact]
public void SniHelper_TruncatedData_Fails()
{
InvalidClientHello(clientHello, id, shouldPass: false);
// moving inside one test because there are more than 3000 cases and they overflow subresults
foreach ((int id, byte[] clientHello) in InvalidClientHelloDataTruncatedBytes())
{
InvalidClientHello(clientHello, id, shouldPass: false);
Copy link
Member

@ManickaP ManickaP Dec 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So now if one of the test fails we won't know which one and also the rest of them won't get executed.
If we're fine with this, no problem. I'm just making sure all the side-effects are understood and agreed on.

Copy link
Contributor Author

@greenEkatherine greenEkatherine Dec 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing this out. I may add additional info to identify failed test, if it helps - we still have an id.

}
}

private void InvalidClientHello(byte[] clientHello, int id, bool shouldPass)
Expand Down Expand Up @@ -94,7 +97,7 @@ public static IEnumerable<object[]> InvalidClientHelloData()
}
}

public static IEnumerable<object[]> InvalidClientHelloDataTruncatedBytes()
public static IEnumerable<Tuple<int, byte[]>> InvalidClientHelloDataTruncatedBytes()
Copy link
Member

@danmoseley danmoseley Dec 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, as a style thing, we seem (I think?) to most often use the (int, byte[]) syntax (possibly with names) not the old Tuple<X, Y> syntax.

{
// converting to base64 first to remove duplicated test cases
var uniqueInvalidHellos = new HashSet<string>();
Expand All @@ -115,7 +118,7 @@ public static IEnumerable<object[]> InvalidClientHelloDataTruncatedBytes()
foreach (string invalidClientHello in uniqueInvalidHellos)
{
id++;
yield return new object[] { id, Convert.FromBase64String(invalidClientHello) };
yield return new Tuple<int, byte[]>(id, Convert.FromBase64String(invalidClientHello));
}
}

Expand Down