Skip to content

Conversation

@eerhardt
Copy link
Member

@eerhardt eerhardt commented Dec 6, 2021

Removing SessionId check in IsWindowsService(). This check is not correct when the process is being run in a Windows container. The container will get a different SessionId.

Fix #52416

Removing SessionId check in IsWindowsService(). This check is not correct when the process is being run in a Windows container. The container will get a different SessionId.

Fix dotnet#52416
@ghost
Copy link

ghost commented Dec 6, 2021

Tagging subscribers to this area: @dotnet/area-extensions-hosting
See info in area-owners.md if you want to be subscribed.

Issue Details

Removing SessionId check in IsWindowsService(). This check is not correct when the process is being run in a Windows container. The container will get a different SessionId.

Fix #52416

Author: eerhardt
Assignees: -
Labels:

area-Extensions-Hosting

Milestone: -

Copy link
Member

@Tratcher Tratcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This eliminates some false negatives, but introduces the possibility of some false positives. Those seem less likely, and easier to work around.

@eerhardt eerhardt merged commit 36bf84f into dotnet:main Dec 9, 2021
@eerhardt eerhardt deleted the Fix52416 branch December 9, 2021 17:53
@ghost ghost locked as resolved and limited conversation to collaborators Jan 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

App does not Run as a service in a Windows Container

2 participants