Use separate partials for iOS&tvOS instead of UnknowUnix in System.Diagnostics.Process #61871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…agnostics.Process
|
Tagging subscribers to this area: @dotnet/area-system-diagnostics-process Issue DetailsRe-using UnknownUnix partials with UnsupportedOSPlatform annotations for iOS&tvOS in System.Diagnostics.Process doesn't seem to be the right choice (see #61659 (comment)). To fix it, this PR is going to add separate partials for iOS&tvOS and clean up UnknownUnix files from PSNE annotations.
|
marek-safar
reviewed
Nov 22, 2021
src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.iOS.cs
Show resolved
Hide resolved
|
/azp run runtime-manual |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-manual |
|
Azure Pipelines successfully started running 1 pipeline(s). |
akoeplinger
approved these changes
Nov 24, 2021
This was referenced Nov 29, 2021
MaximLipnin
added a commit
to MaximLipnin/runtime
that referenced
this pull request
Dec 1, 2021
…agnostics.Process (dotnet#61871)
steveisok
pushed a commit
that referenced
this pull request
Dec 2, 2021
#62235) * Exclude the managed code around libproc on iOS/tvOS (#61590) Since libproc is a private Apple API, it is not available on iOS/tvOS and should be excluded (see #61265 (comment) and above for more details). This PR excludes $(CommonPath)Interop\OSX\Interop.libproc.cs on the iOS/tvOS as well as makes some methods in Process, ProcessManager, and ProcessThread classes calling that API throw PNSE so that for iOS/tvOS it's possible to re-use the respective *.UnknownUnix.cs parts. * [iOS] Follow up changes for 61590 (#61670) This is a follow up PR for #61590. It includes: - additional UnsupportedOSPlatform annotations for some System.Diagnostics.Process APIs throwing PNSE on iOS/tvOS (they started doing so after excluding some managed logic around librpoc ) - fixing a bit ugly workaround for CS0649 (see https://github.com/dotnet/runtime/pull/61590/files#r749525127) - used a local pragma in the ThreadInfo class. - skipping the respective S.D.P. tests ( it will address [iOS/tvOS] System.Diagnostics.Tests.ProcessTests.TestGetProcesses fails on devices #60588 as well) * Skip System.Diagnostics.TextWriterTraceListenerTests.XmlWriterTraceListenerTests on iOS/tvOS (#61807) This marks System.Diagnostics.TextWriterTraceListenerTests.XmlWriterTraceListenerTests withSkipOnPlatform attribute for iOS/tvOS as those tests try to create a process info, which throws PNSE after S.D.Process API's around libproc have been excluded in #61590. * Disable several failing tests on iOSSimulator arm64 #61826 A few tests popped up as failures on the rolling build due to parts of System.Diagnostics.Process throwing PNSE. Disabled the functional tests from running on arm64 as mlaunch can't detect the return code. * Use separate partials for iOS&tvOS instead of UnknowUnix in System.Diagnostics.Process (#61871) * Remove NoWarn removal
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-using UnknownUnix partials with UnsupportedOSPlatform annotations for iOS&tvOS in System.Diagnostics.Process doesn't seem to be the right choice (see #61659 (comment)). To fix it, this PR is going to add separate partials for iOS&tvOS and clean up UnknownUnix files from PSNE annotations.