Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] renames and cleanup before modularization #61596

Merged
merged 10 commits into from
Nov 17, 2021

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Nov 15, 2021

  • rename main javaScript files to main.js and test-main.js
  • sample and test script cleanup
  • rename set_exit_code method
  • rewrite test start as async method
  • improve script loading via script element on page in test
  • use BINDING.bind_static_method instead of INTERNAL where possible
  • better .d.ts exports
  • formatted html files
  • moved dotnet IFFE out of emcc Closure compiled section and re-enabled terser() and ES2018 target.

@pavelsavara pavelsavara added the arch-wasm WebAssembly architecture label Nov 15, 2021
@pavelsavara pavelsavara added this to the 7.0.0 milestone Nov 15, 2021
@ghost
Copy link

ghost commented Nov 15, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • rename main javaScript files to main.js and test-main.js
  • sample and test script cleanup
  • rename set_exit_code method
  • rewrite test start as async method
  • improve script loading via script element on page in test
  • use BINDING.bind_static_method instead of INTERNAL where possible
  • better .d.ts exports
  • formatted html files
Author: pavelsavara
Assignees: -
Labels:

arch-wasm

Milestone: 7.0.0

@kg
Copy link
Member

kg commented Nov 15, 2021

Happy to finally rename runtime to something reasonable

- move dotnet to -extern-pre-js
- re-enable JS minification
- rename main javaScript files to main.js and test-main.js
- sample and test script cleanup
- rename set_exit_code method
- rewrite test start as async method
- improve script loading via script element on page in test
- use BINDING.bind_static_method instead of INTERNAL where possible
- better .d.ts exports
- formatted html files
@pavelsavara pavelsavara marked this pull request as ready for review November 16, 2021 06:12
@pavelsavara
Copy link
Member Author

This passed CI tests with full matrix. I also tested debugger unit tests and debugger in Blazor app manually.

src/mono/wasm/test-main.js Outdated Show resolved Hide resolved
src/mono/wasm/test-main.js Show resolved Hide resolved
src/mono/wasm/runtime/exports.ts Show resolved Hide resolved
- renamed modules.ts to imports.ts which makes more sense
- improved error propagation
- renamed __initializeImportsAndExports
@thaystg
Copy link
Member

thaystg commented Nov 16, 2021

Debugger tests -> passing.
Debug a Blazor App -> working.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants