Fix setting pipe used in PAL_ProbeMemory as nonblocking #61126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vikas Tikoo <[email protected]>
ghost
added
the
community-contribution
adamsitnik
approved these changes
Nov 24, 2021
There was a problem hiding this comment.
@vtikoo have you hit any particular problem or just found a possible issue when analyzing the source code?
LGTM, thank you!
Comment on lines
+753
to
+754
| flags = fcntl(fds[0], F_GETFL, 0); | ||
| fcntl(fds[0], F_SETFL, flags | O_NONBLOCK); |
There was a problem hiding this comment.
an alternative would be using pipe2 but this would require an #ifdef
There was a problem hiding this comment.
Do some targets not support pipe2?
There was a problem hiding this comment.
pipe2 is Linux-specific and we support macOS and few other Unix-like OSese. The current solution is good, I am going to merge the PR.
This was referenced Nov 29, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vikas Tikoo [email protected]