[wasm] preparation for module encapsulation #60928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing Issue Details
|
kg
requested changes
Oct 27, 2021
pavelsavara
force-pushed
the
wasm_encapsulate_prep
branch
from
7c95dba
to
64e59de
Compare
kg
approved these changes
Oct 28, 2021
- clarified runtime-test.js based on Daniel's draft. - extracted mono_wasm_invoke_js and mono_wasm_compile_function out of C macro into proper .ts function - wrapped access to API via globalThis with warning on first use - added cwraps.mono_wasm_add_assembly and cwraps.mono_wasm_load_runtime which Blazor uses - fixed closures for generated functions, so that they don't use global Module reference - mono_wasm_invoke_js now uses new Function instead of eval() - removed deprecated Blazor functions - fixed lint issues Co-authored-by: Daniel Genkin <[email protected]>
pavelsavara
force-pushed
the
wasm_encapsulate_prep
branch
from
64e59de
to
930a791
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runtime-test.jsbased on Daniel's draft.mono_wasm_invoke_jsandmono_wasm_compile_functionout of C macro into proper .ts functionglobalThiswith warning on first usecwraps.mono_wasm_add_assemblyandcwraps.mono_wasm_load_runtimewhich Blazor usesModulereferencemono_wasm_invoke_jsnow usesnew Functioninstead ofeval()