Use SDK's .NETFramework refpack version #60555
Conversation
|
Converting to draft as evaluation order is wrong. |
Use the MicrosoftNETFrameworkReferenceAssembliesLatestPackageVersion property which is exposed by the SDK instead of the one exposed by Arcade to make sure that we are always targeting the latest version.
ViktorHofer
force-pushed
the
ViktorHofer-patch-1
branch
from
2690f99 to
33d61ea
Compare
|
Drawing failures were disabled with #60746. |
eerhardt
left a comment
eerhardt
left a comment
There was a problem hiding this comment.
Awesome! Thanks for making this area better.
LGTM
| <InnerBuildArgs>$(InnerBuildArgs) --verbosity $(LogVerbosity)</InnerBuildArgs> | ||
| <InnerBuildArgs>$(InnerBuildArgs) --nodereuse false</InnerBuildArgs> | ||
| <InnerBuildArgs>$(InnerBuildArgs) --warnAsError false</InnerBuildArgs> | ||
| <InnerBuildArgs>$(InnerBuildArgs) /p:MicrosoftNetFrameworkReferenceAssembliesVersion=1.0.0</InnerBuildArgs> |
There was a problem hiding this comment.
Do you think it would make sense to log an issue to remove MicrosoftNetFrameworkReferenceAssembliesVersion from arcade?
That version is really out of date, and instead of having people use the arcade version, they should just be using $(MicrosoftNETFrameworkReferenceAssembliesLatestPackageVersion), like we are now.
There was a problem hiding this comment.
Apparently I already removed the feature in Arcade with dotnet/arcade@0f412eb but forgot to remove the property. I will send a PR to clean that up and as I see some consumers, will make sure to announce the change to get people off it.
|
The drawing failure is 16e1d9b which was fixed a few days ago. |
ghost
locked as resolved and limited conversation to collaborators
Use the MicrosoftNETFrameworkReferenceAssembliesLatestPackageVersion property which is exposed by the SDK instead of the one exposed by Arcade to make sure that we are always targeting the latest version.