Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WebSocket cancel test for non-browser #60173

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

CarnaViire
Copy link
Member

Non-browser WS server used for ConnectAsync_Cancel_ThrowsCancellationException doesn't support "delay20sec", only "delay10sec". This basically reverts the change in this line from #58199 for non-browser platforms.

Contributes to #58355

/cc @pavelsavara @ManickaP

@CarnaViire
Copy link
Member Author

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@CarnaViire
Copy link
Member Author

Outerloop test failures are unrelated: System.Net.Http #60190, System.Diagnostics #60191

@CarnaViire CarnaViire merged commit 17a1e38 into dotnet:main Oct 8, 2021
@CarnaViire CarnaViire deleted the ws-fix-cancel-test branch October 8, 2021 17:57
@karelz karelz added this to the 7.0.0 milestone Oct 14, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants