Skip to content

Issue 55685 processname optimisation #59672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Dec 7, 2021
Merged

Issue 55685 processname optimisation #59672

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
dd7f67b
Implementation
SteveDunn Sep 27, 2021
41e0197
Merge branch 'dotnet:main' into issue-55685-processname-optimisation
SteveDunn Sep 27, 2021
19b9126
Get short name after calling Kernel32.GetProcessName
SteveDunn Sep 28, 2021
8955b32
PR feedback
SteveDunn Sep 28, 2021
901e8f3
PR feedback
SteveDunn Sep 28, 2021
47262da
PR feedback
SteveDunn Sep 29, 2021
8689265
Removed commented out code
SteveDunn Oct 8, 2021
ac70497
PR feedback
SteveDunn Oct 8, 2021
c5a2790
If processinfo is already available, use that, otherwise use the quic…
SteveDunn Oct 10, 2021
9f69e34
PR feedback
SteveDunn Oct 11, 2021
38e3d14
PR feedback
SteveDunn Oct 11, 2021
3227f87
Update src/libraries/Common/src/Interop/Windows/Kernel32/Interop.GetP…
SteveDunn Dec 7, 2021
f07a0bc
Update src/libraries/Common/src/Interop/Windows/Kernel32/Interop.GetP…
SteveDunn Dec 7, 2021
3728a1f
Update src/libraries/System.Diagnostics.Process/src/System/Diagnostic…
SteveDunn Dec 7, 2021
fcb47a9
Update src/libraries/System.Diagnostics.Process/src/System/Diagnostic…
SteveDunn Dec 7, 2021
23cd323
Update src/libraries/System.Diagnostics.Process/src/System/Diagnostic…
SteveDunn Dec 7, 2021
d4c2e86
Update src/libraries/System.Diagnostics.Process/src/System/Diagnostic…
SteveDunn Dec 7, 2021
96b88b4
Apply suggestions from code review
adamsitnik Dec 7, 2021
67732e4
handle ERROR_INSUFFICIENT_BUFFER
adamsitnik Dec 7, 2021
6676175
discard process name on Refresh
adamsitnik Dec 7, 2021
08ec6d0
Merge remote-tracking branch 'upstream/main' into issue-55685-process…
adamsitnik Dec 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.Windows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -897,6 +897,11 @@ public string ProcessName
{
EnsureState(State.HaveNonExitedId);

if (_processInfo?.ProcessName != null)
{
return _processInfo!.ProcessName;
}

if (_processName == null)
{
EnsureState(State.HaveId);
Expand Down