Dependency Injection support for ValueTypes as Services #59625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @eerhardt, @maryamariyan Issue DetailsWe only thing missing to support ValueTypes as Services I am also fixing several tests that were building the ServiceProvider
|
teo-tsirpanis
suggested changes
Sep 26, 2021
...s/Microsoft.Extensions.DependencyInjection/src/ServiceLookup/ILEmit/ILEmitResolverBuilder.cs
Outdated
Show resolved
Hide resolved
...s/Microsoft.Extensions.DependencyInjection/src/ServiceLookup/ILEmit/ILEmitResolverBuilder.cs
Outdated
Show resolved
Hide resolved
...s/Microsoft.Extensions.DependencyInjection/src/ServiceLookup/ILEmit/ILEmitResolverBuilder.cs
Outdated
Show resolved
Hide resolved
...s/Microsoft.Extensions.DependencyInjection/src/ServiceLookup/ILEmit/ILEmitResolverBuilder.cs
Outdated
Show resolved
Hide resolved
...s/Microsoft.Extensions.DependencyInjection/src/ServiceLookup/ILEmit/ILEmitResolverBuilder.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Sep 26, 2021
...s/Microsoft.Extensions.DependencyInjection/src/ServiceLookup/ILEmit/ILEmitResolverBuilder.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Sep 27, 2021
...ies/Microsoft.Extensions.DependencyInjection/tests/DI.Tests/ServiceProviderContainerTests.cs
Show resolved
Hide resolved
eerhardt
reviewed
Sep 27, 2021
...ies/Microsoft.Extensions.DependencyInjection/tests/DI.Tests/ServiceProviderContainerTests.cs
Outdated
Show resolved
Hide resolved
The only that was thing missing to support ValueTypes as Services was box the result when visiting constructors call sites. I am also fixing several tests that were building the ServiceProvider using the default engine, instead of relying on each specific engine. fix dotnet#42160
allantargino
force-pushed
the
issue-42160
branch
from
371fa99 to
8ff63c6
Compare
eerhardt
approved these changes
Sep 28, 2021
There was a problem hiding this comment.
Thanks for the great work here, @allantargino. And thanks for separating the changes. It makes it much easier to review.
|
Thank you @eerhardt for the reviews and best practices recommendations, I am learning a ton 👍 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only thing that was missing to support ValueTypes as Services was box the result when visiting constructors call sites.
I am also fixing several tests that were building the ServiceProvider using the default ServiceProviderEngine, instead of relying on each specific engine abstract creation method.
fix #42160