-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regressions due to pipeline stalls introduced in #59415 #59497
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
384a030
Undo shift-back with AVX register for block copy, use GPR for remaind…
alexcovington 78ad9c9
Cleanup
alexcovington 5ff211c
Use GPR instead of SIMD for block init remainder
alexcovington 3191bd4
JIT formatting
alexcovington 237ce31
More JIT formatting
alexcovington 39c3f2f
Fixed local jit-format.bat, formatting should be correct now
alexcovington b0e0817
Using older jit-format.bat on backup machine
alexcovington 6b07cdf
Revert "Using older jit-format.bat on backup machine"
alexcovington 3f612ee
Revert "Fixed local jit-format.bat, formatting should be correct now"
alexcovington f8a86eb
Revert "More JIT formatting"
alexcovington d856476
Revert "JIT formatting"
alexcovington ddd8ecf
Undo weird JIT formatting, add note for YMM->XMM step down
alexcovington File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably worth adding a line of comment that further moves are not possible using
YMM
and so we will tryXMM
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good point. I'll add a note.