Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize StringBuilder by embracing spans and ISpanFormattable more. #58907

Closed
wants to merge 13 commits into from
Closed

Optimize StringBuilder by embracing spans and ISpanFormattable more. #58907

wants to merge 13 commits into from

Commits on Sep 9, 2021

  1. Eliminate pinning in StringBuilder.Append(ReadOnlySpan).

    @teo-tsirpanis
    teo-tsirpanis committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    698bc15 View commit details
    Browse the repository at this point in the history

  2. Eliminate pinning in all StringBuilder.Append overloads.

    @teo-tsirpanis
    teo-tsirpanis committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    a5ba300 View commit details
    Browse the repository at this point in the history

  3. Eliminate pinning in all StringBuilder.AppendJoin overloads.

    @teo-tsirpanis
    teo-tsirpanis committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    8cbdef5 View commit details
    Browse the repository at this point in the history

  4. Eliminate pinning in all StringBuilder.Insert overloads.

    @teo-tsirpanis
    teo-tsirpanis committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    683d290 View commit details
    Browse the repository at this point in the history

  5. Eliminate pinning in StringBuilder.ToString(int, int).

    @teo-tsirpanis
    teo-tsirpanis committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    99d9fbc View commit details
    Browse the repository at this point in the history

  6. Optimize the StringBuilder.Insert overloads of primitives. 

    And streamline the character array Insert overload.
    @teo-tsirpanis
    teo-tsirpanis committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    85bcf34 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2021

  1. Throw OOM when StringBuilder.Insert exceeds capacity, like before. 

    And move the capacity check in Append(ReadOnlySpan<char>).
    @teo-tsirpanis
    teo-tsirpanis committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    3e5700c View commit details
    Browse the repository at this point in the history

  2. Use ReadOnlySpan.TryCopyTo in one occasion, saving a branch.

    @teo-tsirpanis
    teo-tsirpanis committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    16488d5 View commit details
    Browse the repository at this point in the history

  3. Fix the last failing test.

    @teo-tsirpanis
    teo-tsirpanis committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    2d79d36 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2021

  1. Remove all explicit usages of the this keyword.

    @teo-tsirpanis
    teo-tsirpanis committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    b9f886e View commit details
    Browse the repository at this point in the history

  2. Address PR feedback.

    @teo-tsirpanis
    teo-tsirpanis committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    9c09d44 View commit details
    Browse the repository at this point in the history

  3. Use ReadOnlySpan.IsEmpty uniformly.

    @teo-tsirpanis
    teo-tsirpanis committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    3cbbc82 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2021

  1. Merge branch 'main' into stringbuilder-span

    @teo-tsirpanis
    teo-tsirpanis committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    036d8c9 View commit details
    Browse the repository at this point in the history