-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip eventpipe_readevents for arm32 #58545
Conversation
Originally there was only one eventpipe test, and eventpipe_readevents was added in dotnet#37002. Both should be skipped for the same reason.
@davmason is there any reason we would need to disable eventpipe profiler tests on arm32 but not regular eventpipe tests? I would expect TraceEvent alignment issues to affect all variants of EventPipe tests. |
The profiler tests construct EventPipe data blobs manually, so it's possible the tests themselves are hitting alignment issues not seen in TraceEvent. I don't know if that's what happening, but it is a potential difference. |
@gbalykov is this still necessary? |
I think so, I do not see any changes in main branch related to this |
Thanks for the contribution @gbalykov! I'm merging this PR. According to runfo we have a couple of test failures in the last week on arm, and so we should disable the failing test while we investigate the failures.
|
Originally there was only one eventpipe test, and eventpipe_readevents was added in #37002.
Both should be skipped for the same reason.
cc @alpencolt