Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nullable annotation for System.Windows.Extensions #57896

Merged
merged 12 commits into from
Nov 24, 2021
Merged

Nullable annotation for System.Windows.Extensions #57896

merged 12 commits into from
Nov 24, 2021

Conversation

huoyaoyuan
Copy link
Member

Part of #41720

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Aug 22, 2021
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@huoyaoyuan
Copy link
Member Author

How to verify the ref source? I tried /t:GenerateReferenceAssemblySource but it has no effect.

@ViktorHofer
Copy link
Member

ViktorHofer commented Sep 7, 2021 •
edited
Loading

cc @Anipik @ericstj (for some reason the bot didn't send out a notification).

stephentoub
stephentoub requested changes Sep 7, 2021
View reviewed changes
src/libraries/System.Windows.Extensions/ref/System.Windows.Extensions.cs Outdated Show resolved Hide resolved
src/libraries/System.Windows.Extensions/ref/System.Windows.Extensions.cs Outdated Show resolved Hide resolved
src/libraries/System.Windows.Extensions/src/System/Media/SoundPlayer.cs Outdated Show resolved Hide resolved
src/libraries/System.Windows.Extensions/src/System/Media/SoundPlayer.cs Show resolved Hide resolved
src/libraries/System.Windows.Extensions/ref/System.Windows.Extensions.cs Outdated Show resolved Hide resolved
src/libraries/System.Windows.Extensions/src/System/Media/SoundPlayer.cs Outdated Show resolved Hide resolved
src/libraries/System.Windows.Extensions/src/System/Media/SoundPlayer.cs
@@ -271,7 +274,9 @@ private void LoadSync()
_stream = webResponse.GetResponseStream();
}

if (_stream.CanSeek)
// DO NOT assert - NRE is expected for null stream
// See SoundPlayerTests.Load_NullStream_ThrowsNullReferenceException
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be worth opening an issue for this to decide separately whether we should throw a better exception in that case.

src/libraries/System.Windows.Extensions/ref/System.Windows.Extensions.cs Show resolved Hide resolved
@huoyaoyuan huoyaoyuan mentioned this pull request Sep 7, 2021
Open
@runfoapp runfoapp bot mentioned this pull request Sep 24, 2021
Closed
@huoyaoyuan
Copy link
Member Author

@stephentoub Is this now ready?

stephentoub
stephentoub approved these changes Oct 6, 2021
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@stephentoub stephentoub closed this Oct 6, 2021
@stephentoub stephentoub reopened this Oct 6, 2021
@runfoapp runfoapp bot mentioned this pull request Oct 6, 2021
Closed
@ericstj
Copy link
Member

ericstj commented Oct 25, 2021

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@huoyaoyuan
Copy link
Member Author

@stephentoub ping on this

@stephentoub stephentoub merged commit 89e3040 into dotnet:main Nov 24, 2021
@huoyaoyuan huoyaoyuan deleted the system-windows-extensions branch November 25, 2021 07:41
This was referenced Nov 29, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@danmoseley danmoseley mentioned this pull request Dec 3, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

Assignees

@stephentoub stephentoub

Labels
area-Microsoft.Win32 community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@huoyaoyuan @ViktorHofer @ericstj @stephentoub