Rename FEATURE_READYTORUN{_COMPILER,} in JIT #57704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
community-contribution
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsAfter the removal of crossgen1
|
|
cc @jkoritzinsky, @jkotas, so there is only one kind of |
|
@JulieLeeMSFT, I think 7.0.0 would be the correct milestone, since it's based on a similar PR #57672. |
jkoritzinsky
approved these changes
Aug 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the removal of crossgen1
FEATURE_READYTORUN_COMPILE(#57672), there is onlyFEATURE_READYTORUNin runtime left. The redefinition of compiler flag is not required in cmake for JIT anymore, which apparently was there to disambiguate names.