Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Group 4] Enable nullable annotations for Microsoft.Extensions.Configuration.CommandLine #57432

Merged
merged 14 commits into from
Nov 19, 2021
Merged

[Group 4] Enable nullable annotations for Microsoft.Extensions.Configuration.CommandLine #57432

merged 14 commits into from
Nov 19, 2021

Conversation

maxkoshevoi
Copy link
Contributor

@maxkoshevoi maxkoshevoi commented Aug 15, 2021 •
edited
Loading

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Aug 15, 2021
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Aug 15, 2021

Tagging subscribers to this area: @maryamariyan, @safern
See info in area-owners.md if you want to be subscribed.

Issue Details

Related to #43605, #54012

Notes:

Author: maxkoshevoi
Assignees: -
Labels:

new-api-needs-documentation, area-Extensions-Configuration, community-contribution
Milestone: -

@maxkoshevoi maxkoshevoi changed the title Enable nullable annotations for Microsoft.Extensions.Configuration.CommandLine [Group 4] Enable nullable annotations for Microsoft.Extensions.Configuration.CommandLine Aug 15, 2021
@karelz karelz mentioned this pull request Aug 16, 2021
Closed
@maryamariyan maryamariyan added this to the 7.0.0 milestone Aug 17, 2021
@maxkoshevoi
Merge branch 'main' into mk/43605-Configuration-CommandLine
81b49ec
@maxkoshevoi
DisableImplicitAssemblyReferences
dbd2ace
@maxkoshevoi
Merge branch 'main' into mk/43605-Configuration-CommandLine
8113acb 
# Conflicts:
#	src/libraries/Microsoft.Extensions.Configuration.Abstractions/ref/Microsoft.Extensions.Configuration.Abstractions.csproj
#	src/libraries/Microsoft.Extensions.Configuration.Abstractions/src/Microsoft.Extensions.Configuration.Abstractions.csproj
#	src/libraries/Microsoft.Extensions.Configuration.CommandLine/ref/Microsoft.Extensions.Configuration.CommandLine.csproj
#	src/libraries/Microsoft.Extensions.Configuration.CommandLine/src/Microsoft.Extensions.Configuration.CommandLine.csproj
#	src/libraries/Microsoft.Extensions.Configuration/ref/Microsoft.Extensions.Configuration.csproj
#	src/libraries/Microsoft.Extensions.Configuration/src/Microsoft.Extensions.Configuration.csproj
@maxkoshevoi maxkoshevoi marked this pull request as draft October 4, 2021 19:04
@runfoapp runfoapp bot mentioned this pull request Oct 7, 2021
Closed
@maxkoshevoi maxkoshevoi marked this pull request as ready for review October 13, 2021 08:02
@eerhardt
Copy link
Member

@maxkoshevoi - Do you think you can make the same changes here as I did in #57433?

  • Merge with main
  • Add the necessary TFMs to the .csprojs

We may need to wait for #57433 to be merged in order to get the changes to MS.Ext.Configuration I made. Or you can make them now, and we can merge any conflicts once the first PR goes in.

eerhardt
eerhardt approved these changes Nov 19, 2021
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution here, @maxkoshevoi.

I pushed a change to fix the NetCoreAppMinimum build.

Will merge when the CI is green.

@eerhardt eerhardt merged commit 8b1a0c8 into dotnet:main Nov 19, 2021
@maxkoshevoi maxkoshevoi deleted the mk/43605-Configuration-CommandLine branch November 20, 2021 01:38
This was referenced Nov 29, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eerhardt eerhardt eerhardt approved these changes

Assignees

@eerhardt eerhardt

Labels
area-Extensions-Configuration community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@maxkoshevoi @eerhardt @maryamariyan