Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move corehost.proj to corehost directory #57036

Merged
merged 2 commits into from
Aug 9, 2021

Conversation

am11
Copy link
Member

@am11 am11 commented Aug 7, 2021

This is done by sharing GetProductVersions via top-level targets.

@ghost
Copy link

ghost commented Aug 7, 2021

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

This is done by sharing GetProductVersions via top-level targets.

Author: am11
Assignees: -
Labels:

area-Host

Milestone: -

@am11 am11 marked this pull request as ready for review August 8, 2021 00:59
@am11
Copy link
Member Author

am11 commented Aug 8, 2021

@VSadov, @ViktorHofer a followup on #48071; now there is only one dependency target left which is shared between packs and corehost, I have moved it to the shared targets file.

Directory.Build.targets Outdated Show resolved Hide resolved
@ViktorHofer
Copy link
Member

These failures are definitely unrelated:

/Users/runner/work/1/s/eng/testing/tests.mobile.targets(189,5): error : [System.Net.Http.dll] Unable to compile method 'void System.Net.Http.Http3RequestStream/<SendAsync>d__28:MoveNext ()' due to: 'Invalid IL code in System.Net.Http.Http3RequestStream/<SendAsync>d__28:MoveNext (): IL_05e1: pop        [/Users/runner/work/1/s/src/tests/FunctionalTests/iOS/Simulator/AOT/iOS.Simulator.Aot.Test.csproj]
/Users/runner/work/1/s/eng/testing/tests.mobile.targets(189,5): error : [System.Net.Http.dll]  assembly:<unknown assembly> type:<unknown type> member:(null)'. [/Users/runner/work/1/s/src/tests/FunctionalTests/iOS/Simulator/AOT/iOS.Simulator.Aot.Test.csproj]
/Users/runner/work/1/s/eng/testing/tests.mobile.targets(189,5): error : [System.Net.Http.dll] Unable to compile method 'void System.Net.Http.Http3RequestStream/<SendAsync>d__28:MoveNext ()' due to: 'Invalid IL code in System.Net.Http.Http3RequestStream/<SendAsync>d__28:MoveNext (): IL_05e1: pop        [/Users/runner/work/1/s/src/tests/FunctionalTests/iOS/Simulator/LambdaCompilerAOT/iOS.Simulator.LambdaCompilerAot.Test.csproj]
/Users/runner/work/1/s/eng/testing/tests.mobile.targets(189,5): error : [System.Net.Http.dll]  assembly:<unknown assembly> type:<unknown type> member:(null)'. [/Users/runner/work/1/s/src/tests/FunctionalTests/iOS/Simulator/LambdaCompilerAOT/iOS.Simulator.LambdaCompilerAot.Test.csproj]
/Users/runner/work/1/s/eng/testing/tests.mobile.targets(189,5): error : [System.Net.Http.dll] Unable to compile method 'void System.Net.Http.Http3RequestStream/<SendAsync>d__28:MoveNext ()' due to: 'Invalid IL code in System.Net.Http.Http3RequestStream/<SendAsync>d__28:MoveNext (): IL_05e1: pop        [/Users/runner/work/1/s/src/tests/FunctionalTests/iOS/Simulator/XmlFormatWriterGeneratorAOT/iOS.Simulator.XmlFormatWriterGeneratorAot.Test.csproj]
/Users/runner/work/1/s/eng/testing/tests.mobile.targets(189,5): error : [System.Net.Http.dll]  assembly:<unknown assembly> type:<unknown type> member:(null)'. [/Users/runner/work/1/s/src/tests/FunctionalTests/iOS/Simulator/XmlFormatWriterGeneratorAOT/iOS.Simulator.XmlFormatWriterGeneratorAot.Test.csproj]
/Users/runner/work/1/s/eng/testing/tests.mobile.targets(189,5): error : [System.Net.Http.dll] Unable to compile method 'void System.Net.Http.Http3RequestStream/<SendAsync>d__28:MoveNext ()' due to: 'Invalid IL code in System.Net.Http.Http3RequestStream/<SendAsync>d__28:MoveNext (): IL_05e1: pop        [/Users/runner/work/1/s/src/tests/FunctionalTests/iOS/Simulator/XmlSerializer_Deserialize/iOS.Simulator.XmlSerializer_Deserialize.Test.csproj]
/Users/runner/work/1/s/eng/testing/tests.mobile.targets(189,5): error : [System.Net.Http.dll]  assembly:<unknown assembly> type:<unknown type> member:(null)'. [/Users/runner/work/1/s/src/tests/FunctionalTests/iOS/Simulator/XmlSerializer_Deserialize/iOS.Simulator.XmlSerializer_Deserialize.Test.csproj]
    0 Warning(s)

Reached out to @akoeplinger to understand if there's already an issue for them.

@ViktorHofer ViktorHofer merged commit 25bb59d into dotnet:main Aug 9, 2021
@ViktorHofer
Copy link
Member

Thanks @am11 :)

@am11 am11 deleted the feature/installer/pkgs branch August 9, 2021 10:14
@ghost ghost locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants