Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dispose server connection after client has been disposed #56720

Closed
wants to merge 2 commits into from
Closed

Dispose server connection after client has been disposed #56720

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd93e66
Dispose server connection after client has been disposed
alnikola Aug 2, 2021
9002fe8
Remove test code
alnikola Aug 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2557,7 +2557,6 @@ public async Task ConnectCallback_UseMemoryBuffer_Success(bool useSsl)
}

[ConditionalTheory(nameof(PlatformSupportsUnixDomainSockets))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/44183", TestPlatforms.Windows)]
[InlineData(true)]
[InlineData(false)]
public async Task ConnectCallback_UseUnixDomainSocket_Success(bool useSsl)
Expand All @@ -2584,26 +2583,26 @@ public async Task ConnectCallback_UseUnixDomainSocket_Success(bool useSsl)
return new NetworkStream(clientSocket, ownsSocket: true);
};

GenericLoopbackConnection loopbackConnection;
using (HttpClient client = CreateHttpClient(handler))
{
client.DefaultVersionPolicy = HttpVersionPolicy.RequestVersionExact;

Task<string> clientTask = client.GetStringAsync($"{(options.UseSsl ? "https" : "http")}://{guid}/foo");

Socket serverSocket = await listenSocket.AcceptAsync();
using (GenericLoopbackConnection loopbackConnection = await LoopbackServerFactory.CreateConnectionAsync(socket: null, new NetworkStream(serverSocket, ownsSocket: true), options))
{
await loopbackConnection.InitializeConnectionAsync();
loopbackConnection = await LoopbackServerFactory.CreateConnectionAsync(socket: null, new NetworkStream(serverSocket, ownsSocket: true), options);
await loopbackConnection.InitializeConnectionAsync();

HttpRequestData requestData = await loopbackConnection.ReadRequestDataAsync();
Assert.Equal("/foo", requestData.Path);
HttpRequestData requestData = await loopbackConnection.ReadRequestDataAsync();
Assert.Equal("/foo", requestData.Path);

await loopbackConnection.SendResponseAsync(content: "foo");
await loopbackConnection.SendResponseAsync(content: "foo");

string response = await clientTask;
Assert.Equal("foo", response);
}
string response = await clientTask;
Assert.Equal("foo", response);
}
loopbackConnection.Dispose();
}

[Theory]
Expand Down