Globally disable implicit namespaces #56348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
hoyosjs
approved these changes
Jul 27, 2021
stephentoub
approved these changes
Jul 27, 2021
|
Hello @safern! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Member
|
thanks |
|
Been seeing several PRs like this today. Maybe.... just maybe auto generating global namespaces isn't such a great feature? |
Member
|
@MadsTorgersen where is the right place for folks to give feedback on the implicit usings feature? |
Member
Author
|
@danmoseley I believe it is in the SDK. It was added here: dotnet/sdk#18459 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've hit more instances of this, now when building MSBuild tasks as the MSBuild Task type conflicts with
System.Threading.Tasks.Tasktype which its namespace is implicitly defined.