Fix format errors. #55314
Closed
Fix format errors. #55314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandreenko
added
the
area-CodeGen-coreclr
kunalspathak
reviewed
Jul 8, 2021
| ? spillCandidateRegRecord->assignedInterval->recentRefPosition | ||
| : nullptr; | ||
| if ((recentRefPosition != nullptr) && (recentRefPosition->RegOptional() && | ||
| if ((recentRefPosition != nullptr) && |
Contributor
There was a problem hiding this comment.
My bad for not spotting this formatting error in #55247. I also missed one more change to hoist spillCandidateRegRecord->assignedInterval. Do you mind changing that as well?
Interval* assignedInterval = spillCandidateRegRecord->assignedInterval;
// and then use assingedInterval at multiple places.
Contributor
There was a problem hiding this comment.
You might need to define it after the line:
RegRecord* spillCandidateRegRecord = &linearScan->physRegs[spillCandidateRegNum];
Interval* assignedInterval = spillCandidateRegRecord->assignedInterval;so that you can use it in condition on line 11254 as well.
if ((linearScan->getNextIntervalRef(spillCandidateRegNum, regType) == currentLocation) &&
!assignedInterval->getNextRefPosition()->RegOptional())
{
continue;
}
Contributor
Author
There was a problem hiding this comment.
could you please open a PR with a fix? I think it would be faster and less confusing for the history/blame.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduced by #55247