Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Fix blazor/aot builds #54651

Merged
merged 1 commit into from
Jun 24, 2021
Merged

[wasm] Fix blazor/aot builds #54651

merged 1 commit into from
Jun 24, 2021

Conversation

radical
Copy link
Member

@radical radical commented Jun 23, 2021

dotnet\packs\Microsoft.NET.Runtime.WebAssembly.Sdk\6.0.0-preview.7.21321.15\Sdk\WasmApp.Native.targets(342,5): error : Could not find AOT cross compiler at $(_MonoAotCrossCompilerPath)=

Make sure this is set for the aot code path.

Background:

  • This wasn't getting caught by the Wasm.Build.Tests because they rely on the runtime repo's infrastructure to get all the bits required for building, which includes the cross compiler. So, the correct properties are already set up.

  • In case of workloads though, all this information comes from the packs, including the cross compiler path. There was a recent change to use an item for cross compiler paths(because on other platforms, there could be more than one available cross compiler, eg. android), instead of a property.

  • So, the targets were updated to extract the path in case of wasm

    • but the update was incomplete
    • since this property->item change is only in the Sdk.props for the cross compiler, it comes into play only with workloads!

I have an upcoming PR, which enables running Wasm.Build.Tests with workloads, and that would be able to catch this bug.

`dotnet\packs\Microsoft.NET.Runtime.WebAssembly.Sdk\6.0.0-preview.7.21321.15\Sdk\WasmApp.Native.targets(342,5): error : Could not find AOT cross compiler at $(_MonoAotCrossCompilerPath)=`

Make sure this is set for the aot path.
@radical radical added arch-wasm WebAssembly architecture area-Build-mono labels Jun 23, 2021
@radical radical requested a review from lewing June 23, 2021 22:16
@ghost
Copy link

ghost commented Jun 23, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

dotnet\packs\Microsoft.NET.Runtime.WebAssembly.Sdk\6.0.0-preview.7.21321.15\Sdk\WasmApp.Native.targets(342,5): error : Could not find AOT cross compiler at $(_MonoAotCrossCompilerPath)=

Make sure this is set for the aot path.

Author: radical
Assignees: -
Labels:

arch-wasm, area-Build-mono

Milestone: -

@lewing
Copy link
Member

lewing commented Jun 23, 2021

/backport to release/6.0-preview6

@github-actions
Copy link
Contributor

Started backporting to release/6.0-preview6: https://github.com/dotnet/runtime/actions/runs/966012609

@dotnet dotnet deleted a comment from github-actions bot Jun 23, 2021
@dotnet dotnet deleted a comment from github-actions bot Jun 23, 2021
@lewing lewing requested a review from directhex June 23, 2021 22:35
@lewing lewing merged commit dae9156 into dotnet:main Jun 24, 2021
@radical radical deleted the fix-blazor-aot branch June 24, 2021 02:35
steveisok pushed a commit that referenced this pull request Jun 24, 2021
Backport of #54651 to release/6.0-preview6

`dotnet\packs\Microsoft.NET.Runtime.WebAssembly.Sdk\6.0.0-preview.7.21321.15\Sdk\WasmApp.Native.targets(342,5): error : Could not find AOT cross compiler at $(_MonoAotCrossCompilerPath)=`

Make sure this is set for the aot path.

Co-authored-by: Ankit Jain <[email protected]>
thaystg added a commit to thaystg/runtime that referenced this pull request Jun 24, 2021
…bugger2

* origin/main: (107 commits)
  Disable MacCatalyst arm64 PR test runs on staging pipeline (dotnet#54678)
  [WASM] Fix async/await in config loading (dotnet#54652)
  Fix for heap_use_after_free flagged by sanitizer (dotnet#54679)
  [wasm] Bump emscripten to 2.0.23 (dotnet#53603)
  Fix compiler references when building inside VS (dotnet#54614)
  process more TLS frames at one when available (dotnet#50815)
  Add PeriodicTimer (dotnet#53899)
  UdpClient with span support (dotnet#53429)
  exclude fragile tests (dotnet#54671)
  get last error before calling a method that might fail as well (dotnet#54667)
  [FileStream] add tests for device and UNC paths (dotnet#54545)
  Fix sporadic double fd close (dotnet#54660)
  Remove Version.Clone from AssemblyName.Clone (dotnet#54621)
  [wasm] Enable fixed libraries tests (dotnet#54641)
  [wasm] Fix blazor/aot builds (dotnet#54651)
  [mono][wasm] Fix compilation error on wasm (dotnet#54659)
  Fix telemetry for Socket connects to Dns endpoints (dotnet#54071)
  [wasm] Build static components; include hot_reload in runtime (dotnet#54568)
  [wasm][debugger] Reuse debugger-agent on wasm debugger (dotnet#52300)
  Put Crossgen2 in sync with dotnet#54235 (dotnet#54438)
  ...
@ghost ghost locked as resolved and limited conversation to collaborators Jul 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants