[wasm] Fix blazor/aot builds #54651
Merged
[wasm] Fix blazor/aot builds #54651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`dotnet\packs\Microsoft.NET.Runtime.WebAssembly.Sdk\6.0.0-preview.7.21321.15\Sdk\WasmApp.Native.targets(342,5): error : Could not find AOT cross compiler at $(_MonoAotCrossCompilerPath)=` Make sure this is set for the aot path.
|
Tagging subscribers to 'arch-wasm': @lewing Issue Details
Make sure this is set for the aot path.
|
lewing
approved these changes
Jun 23, 2021
|
/backport to release/6.0-preview6 |
|
Started backporting to release/6.0-preview6: https://github.com/dotnet/runtime/actions/runs/966012609 |
steveisok
pushed a commit
that referenced
this pull request
Jun 24, 2021
Backport of #54651 to release/6.0-preview6 `dotnet\packs\Microsoft.NET.Runtime.WebAssembly.Sdk\6.0.0-preview.7.21321.15\Sdk\WasmApp.Native.targets(342,5): error : Could not find AOT cross compiler at $(_MonoAotCrossCompilerPath)=` Make sure this is set for the aot path. Co-authored-by: Ankit Jain <[email protected]>
thaystg
added a commit
to thaystg/runtime
that referenced
this pull request
Jun 24, 2021
…bugger2 * origin/main: (107 commits) Disable MacCatalyst arm64 PR test runs on staging pipeline (dotnet#54678) [WASM] Fix async/await in config loading (dotnet#54652) Fix for heap_use_after_free flagged by sanitizer (dotnet#54679) [wasm] Bump emscripten to 2.0.23 (dotnet#53603) Fix compiler references when building inside VS (dotnet#54614) process more TLS frames at one when available (dotnet#50815) Add PeriodicTimer (dotnet#53899) UdpClient with span support (dotnet#53429) exclude fragile tests (dotnet#54671) get last error before calling a method that might fail as well (dotnet#54667) [FileStream] add tests for device and UNC paths (dotnet#54545) Fix sporadic double fd close (dotnet#54660) Remove Version.Clone from AssemblyName.Clone (dotnet#54621) [wasm] Enable fixed libraries tests (dotnet#54641) [wasm] Fix blazor/aot builds (dotnet#54651) [mono][wasm] Fix compilation error on wasm (dotnet#54659) Fix telemetry for Socket connects to Dns endpoints (dotnet#54071) [wasm] Build static components; include hot_reload in runtime (dotnet#54568) [wasm][debugger] Reuse debugger-agent on wasm debugger (dotnet#52300) Put Crossgen2 in sync with dotnet#54235 (dotnet#54438) ...
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnet\packs\Microsoft.NET.Runtime.WebAssembly.Sdk\6.0.0-preview.7.21321.15\Sdk\WasmApp.Native.targets(342,5): error : Could not find AOT cross compiler at $(_MonoAotCrossCompilerPath)=Make sure this is set for the aot code path.
Background:
This wasn't getting caught by the
Wasm.Build.Testsbecause they rely on theruntimerepo's infrastructure to get all the bits required for building, which includes the cross compiler. So, the correct properties are already set up.In case of workloads though, all this information comes from the packs, including the cross compiler path. There was a recent change to use an item for cross compiler paths(because on other platforms, there could be more than one available cross compiler, eg. android), instead of a property.
So, the targets were updated to extract the path in case of wasm
Sdk.propsfor the cross compiler, it comes into play only with workloads!I have an upcoming PR, which enables running
Wasm.Build.Testswith workloads, and that would be able to catch this bug.