Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CollectionsMarshal.GetValueRefOrAddDefault #54611

Merged
merged 7 commits into from
Jul 15, 2021
Merged

Add CollectionsMarshal.GetValueRefOrAddDefault #54611

merged 7 commits into from
Jul 15, 2021

Commits on Jul 14, 2021

  1. Add CollectionsMarshal.GetValueRefOrAddDefault API

    @Sergio0694
    Sergio0694 committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    ab97762 View commit details
    Browse the repository at this point in the history

  2. Add special path for dictionary resize after insertion

    @Sergio0694
    Sergio0694 committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    92350fd View commit details
    Browse the repository at this point in the history

  3. Add CollectionsMarshal.GetValueRefOrAddDefault tests

    @Sergio0694
    Sergio0694 committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    ffeef77 View commit details
    Browse the repository at this point in the history

  4. Move GetValueRefOrAddDefault impl to separate type 

    This avoids the additional overhead when loading Dictionary<TKey, TValue> instances, especially in AOT scenarios, and it makes the new API pay for play.
    @Sergio0694
    Sergio0694 committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    1d7e386 View commit details
    Browse the repository at this point in the history

  5. Add unit test for randomized hash logic

    @Sergio0694
    Sergio0694 committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    24a22a4 View commit details
    Browse the repository at this point in the history

  6. Apply review feedbacks about internal comments

    @Sergio0694
    Sergio0694 committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    5209a5b View commit details
    Browse the repository at this point in the history

  7. Add missing assertion in unit tests

    @Sergio0694
    Sergio0694 committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    21ab729 View commit details
    Browse the repository at this point in the history