Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MacOS build on 11.x SDK and Catalyst build #54506

Merged
merged 6 commits into from
Jun 27, 2021
Merged

Fix MacOS build on 11.x SDK and Catalyst build #54506

merged 6 commits into from
Jun 27, 2021

Commits on Jun 24, 2021

  1. Fix MacOS build on 11.x SDK and Catalyst build 

    The configure.cmake was not getting the minimum supported OS version because
it was being set via set_compile_options and the config functions can only
get options from CMAKE_XXX_FLAGS.
    @janvorli
    janvorli committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    efd0663 View commit details
    Browse the repository at this point in the history

  2. Add comment explaining why we set the macOS options via CMAKE_XXX_FLAGS

    @janvorli
    janvorli committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    edfc263 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2021

  1. Add diagnostic printing of the configuration

    @janvorli
    janvorli committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    581ca38 View commit details
    Browse the repository at this point in the history

  2. May fix the problem

    @janvorli
    janvorli committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    2bc930c View commit details
    Browse the repository at this point in the history

  3. Hopefully the right fix

    @janvorli
    janvorli committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    7ab601f View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2021

  1. Attempt to fix the coreclr issue

    @janvorli
    janvorli committed Jun 26, 2021
    Configuration menu
    Copy the full SHA
    c1ca06f View commit details
    Browse the repository at this point in the history