Enable more LDAP TLS tests on linux #54377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Contributor
Author
|
I have a question about line 62 in LdapSessionTests.cs: I would enable that test, but it seems that it should be |
krwq
reviewed
Jun 28, 2021
...ryServices.Protocols/src/System/DirectoryServices/Protocols/ldap/LdapSessionOptions.Linux.cs
Show resolved
Hide resolved
krwq
approved these changes
Jun 29, 2021
Contributor
Author
|
@krwq, thanks for reviewing! I see that the tests are all passing now; is there anything else I need to do for this to be merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow up to #52904, this removes the
SupportedOsPlatform("windows")attribute from LdapSessionOptions.SecureSocketLayer, which was causing weird Intellisense issues in VS Code on Linux.It also enables some tests for
LdapSessionOptions.SecureSocketsLayerfor Linux that were missed in the previous PR.