Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jun 17, 2021

Backport of #54361 to release/6.0-preview6

Fix a situation where an optional workload for mobile development was being required everywhere which is blocking the packaging.

/cc @lewing

Customer Impact

Due to an overly lax condition any build would require installing mobile specific tooling.

Testing

Manual testing.

Risk

Very low, this change limits inclusion to the required platforms.

@github-actions github-actions bot requested a review from marek-safar as a code owner June 17, 2021 21:13
@ghost ghost added the area-System.Net label Jun 17, 2021
@ghost
Copy link

ghost commented Jun 17, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #54361 to release/6.0-preview6

/cc @lewing

Customer Impact

Testing

Risk

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Net

Milestone: -

@lewing lewing added the Servicing-consider Issue for next servicing release review label Jun 17, 2021
Copy link
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in chat.

@danmoseley
Copy link
Member

I see both 'NETcore' and 'NETCore' in this file, is casing significant here (in Unix)?

@lewing
Copy link
Member

lewing commented Jun 18, 2021

I see both 'NETcore' and 'NETCore' in this file, is casing significant here (in Unix)?

Fixed (the answer is more uncertain than the fix).

@lewing lewing added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jun 18, 2021
@lewing
Copy link
Member

lewing commented Jun 18, 2021

cc @Anipik @mmitche

@lewing
Copy link
Member

lewing commented Jun 18, 2021

MacCatalyst lane is timing out regularly and the workload isn't actually used there.

@mmitche mmitche merged commit 8bb087d into release/6.0-preview6 Jun 18, 2021
@mmitche mmitche deleted the backport/pr-54361-to-release/6.0-preview6 branch June 18, 2021 04:33
@karelz karelz added this to the 6.0.0 milestone Jul 15, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Net Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants