Skip to content

Remove crossgen from test build and run scripts #54348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2021
Merged

Remove crossgen from test build and run scripts #54348

merged 1 commit into from
Jun 18, 2021
+21 −283

Conversation

@BruceForstall
Copy link
Contributor

#53458 removed crossgen; this removes it from the test scripts.

@ghost
Copy link

ghost commented Jun 17, 2021

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

#53458 removed crossgen; this removes it from the test scripts.

Author: BruceForstall
Assignees: -
Labels:

area-Infrastructure-coreclr
Milestone: -

trylek
trylek approved these changes Jun 17, 2021
View reviewed changes
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup, thanks Bruce!

@BruceForstall
Copy link
Contributor Author

/azp run runtime-coreclr outerloop, runtime-coreclr r2r

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@mangod9
Copy link
Member

mangod9 commented Jun 17, 2021

would this need any change in the pipelines?

@trylek
Copy link
Member

trylek commented Jun 17, 2021

My 1 cent is that all pipelines running the code Bruce is removing should already be on the floor after Manish's change to shut down Crossgen1.

@BruceForstall
Copy link
Contributor Author

My 1 cent is that all pipelines running the code Bruce is removing should already be on the floor after Manish's change to shut down Crossgen1.

That was my guess.

Looks like there are some existing CG2 asserts/failures in the test jobs, though... plus arm64/arm32 legs (or machines in Helix) are in terrible shape, causing lots of failures.

@BruceForstall
Copy link
Contributor Author

Failures are all infra or existing failures.

@BruceForstall BruceForstall merged commit 3174651 into dotnet:main Jun 18, 2021
@BruceForstall BruceForstall deleted the RemoveCrossgenInScripts branch June 18, 2021 23:57
@mangod9 mangod9 mentioned this pull request Jun 20, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Jul 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@trylek trylek trylek approved these changes

@mangod9 mangod9 Awaiting requested review from mangod9

@hoyosjs hoyosjs Awaiting requested review from hoyosjs

Assignees

No one assigned

Labels

area-Infrastructure-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BruceForstall @mangod9 @trylek