simplify gh53564 test #54081
Merged
simplify gh53564 test #54081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josalem
added
test-bug
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti Issue DetailsThe initial version relied too heavily on sleep timing. This does away with that and explicitly sets an event when the success condition has been met. I'll update the 5.0 and 3.1 PRs with this patch on approval.
|
|
Hello @josalem! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
josalem
pushed a commit
that referenced
this pull request
Jun 12, 2021
mmitche
pushed a commit
that referenced
this pull request
Jun 15, 2021
* Fix #53564 * default internal state to DateTime.MaxValue * re-check IsEnabled after not holding lock * add test for setting interval to 0 * simplify fix to just a for loop * remove one more line * Remove loop * Update test to match #54081 Co-authored-by: John Salem <[email protected]>
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial version relied too heavily on sleep timing. This does away with that and explicitly sets an event when the success condition has been met.
I'll update the 5.0 and 3.1 PRs with this patch on approval.
CC @janvorli @tommcdon