Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the unused AEADBCryptHandles.cs #53736

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

teo-tsirpanis
Copy link
Contributor

@teo-tsirpanis teo-tsirpanis commented Jun 4, 2021

Introduced in #52030, AEADBCryptHandles.cs is almost identical to another new file of that PR, BCryptAEADHandleCache.cs. Contrary to the latter however, the former is not used at all (searching AEADBCryptHandles.cs gave only one results on the file itself; presumably it was left by accident and slipped code review). This PR removes it.

@ghost
Copy link

ghost commented Jun 4, 2021

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks
See info in area-owners.md if you want to be subscribed.

Issue Details

Introduced in #52030, AEADBCryptHandles.cs is almost identical to another new file of that PR, BCryptAEADHandleCache.cs. Contrary to the latter however, the former is not used at all (searching AEADBCryptHandles.cs gave only one results on the file itself; persumably it was left by accident and slipped code review). This PR removes it.

Author: teo-tsirpanis
Assignees: -
Labels:

area-System.Security

Milestone: -

Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green. Thanks.

Copy link
Member

@bartonjs bartonjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprise had me waiting until CI confirmed it first, but, yeah. "So long as CI agrees..."

@bartonjs bartonjs merged commit 303e42c into dotnet:main Jun 4, 2021
@bartonjs
Copy link
Member

bartonjs commented Jun 4, 2021

Weird. Thanks for helping keep us tidy 😄.

@teo-tsirpanis teo-tsirpanis deleted the aead-bcrypt-handles branch June 4, 2021 20:47
@ghost ghost locked as resolved and limited conversation to collaborators Jul 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants