Fix Task.Delay() <exception> XML comments
#53392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix `ObjectDisposedException` comments to state that the exception is thrown when the `CancellationTokenSource` of the `CancellationToken` is disposed, and not the `CancellationToken` itself.
|
Tagging subscribers to this area: @carlossanlop Issue DetailsFix
|
sharwell
approved these changes
May 27, 2021
src/libraries/System.Private.CoreLib/src/System/Threading/Tasks/Task.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Sam Harwell <[email protected]>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
ObjectDisposedExceptioncomments to state that the exception isthrown when the
CancellationTokenSourceof theCancellationTokenisdisposed, and not the
CancellationTokenitself.