Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable optimizations for gtFoldExprConst #53347

Merged
merged 1 commit into from
May 31, 2021
Merged

Re-enable optimizations for gtFoldExprConst #53347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions src/coreclr/jit/compiler.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3165,18 +3165,7 @@ class Compiler
//-------------------------------------------------------------------------

GenTree* gtFoldExpr(GenTree* tree);
GenTree*
#ifdef __clang__
// TODO-Amd64-Unix: Remove this when the clang optimizer is fixed and/or the method implementation is
// refactored in a simpler code. This is a workaround for a bug in the clang-3.5 optimizer. The issue is that in
// release build the optimizer is mistyping (or just wrongly decides to use 32 bit operation for a corner case
// of MIN_LONG) the args of the (ltemp / lval2) to int (it does a 32 bit div operation instead of 64 bit) - see
// the implementation of the method in gentree.cpp. For the case of lval1 and lval2 equal to MIN_LONG
// (0x8000000000000000) this results in raising a SIGFPE. The method implementation is rather complex. Disable
// optimizations for now.
__attribute__((optnone))
#endif // __clang__
gtFoldExprConst(GenTree* tree);
GenTree* gtFoldExprConst(GenTree* tree);
GenTree* gtFoldExprSpecial(GenTree* tree);
GenTree* gtFoldBoxNullable(GenTree* tree);
GenTree* gtFoldExprCompare(GenTree* tree);
Expand Down