Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build support for s390x: Fix a few paltests #53288

Merged
merged 1 commit into from
May 26, 2021
Merged

Build support for s390x: Fix a few paltests #53288

merged 1 commit into from
May 26, 2021

Conversation

uweigand
Copy link
Contributor

  • Accommodate platforms (like s390x) where the SIGSEGV fault address
    is only provided on a page granularity by the HW/OS

  • All paltests now pass on s390x

Finished running PAL tests.

PAL Test Results:
  Passed: 696
  Failed: 0

~/runtime/artifacts/bin/coreclr/Linux.s390x.Debug/paltests

* Accommodate platforms (like s390x) where the SIGSEGV fault address
  is only provided on a page granularity by the HW/OS

* All paltests now pass on s390x
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@janvorli
Copy link
Member

The libraries tests failures are unrelated, I've created #53311 to track that issue.

@janvorli janvorli merged commit 8eb1379 into dotnet:main May 26, 2021
@uweigand uweigand deleted the s390x-clr-paltest branch May 26, 2021 20:31
@ghost ghost locked as resolved and limited conversation to collaborators Jun 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants