Skip flakey mobile library test crashes #52931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdh1418
force-pushed
the
skip_flakey_mobile_library_test_crashes
branch
from
e9ea318
to
648c986
Compare
akoeplinger
approved these changes
May 19, 2021
src/libraries/tests.proj
Outdated
| <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Private.Xml/tests/XPath/XPathDocument/System.Xml.XPath.Tests.csproj" /> | ||
| <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Private.Uri/tests/ExtendedFunctionalTests/System.Private.Uri.ExtendedFunctional.Tests.csproj" /> | ||
| <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Reflection.DispatchProxy/tests/System.Reflection.DispatchProxy.Tests.csproj" /> | ||
| <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Reflection.Emit/tests/System.Reflection.Emit.Tests.csproj" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup Condition="'$(TargetOS)' == 'Android' and '$(TargetArchitecture)' == 'x64'"> |
There was a problem hiding this comment.
nit: this and other Android ItemGroups should have the RunDisabledAndroidTests condition so we can still run them (btw. do we have a draft PR which runs all the tests somewhere?)
There was a problem hiding this comment.
Good catch! I'll put up a draft PR to run all of these tests as well.
There was a problem hiding this comment.
We'll need to bump this #50095
akoeplinger
approved these changes
May 19, 2021
added 6 commits
May 19, 2021 16:38
…ests on build lane
akoeplinger
approved these changes
May 21, 2021
akoeplinger
reviewed
May 21, 2021
added 6 commits
May 21, 2021 09:31
…library_test_crashes
|
The test suites failing on |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The work done in #50800 and #51491 addressed the majority of test failures and crashes in Android, iOS, tvOS, and MacCatalyst. Addressing flakey tests failures and flakey test suite crashes (where the suite crashes in CI but runs and passes locally) is an ongoing process.
In this dropbox paper, many lanes on the
runtime-stagingpipeline are monitored to see which test suites fail.This PR adds the failing test suites to test exclusions in
tests.projand will fall under the issue #52615.