-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix WaitForConnectionAsync when NamedPipeServerStream is disposed #52825
Merged
stephentoub
merged 8 commits into
dotnet:main
from
manandre:dispose-shared-namedpipeserverstream
Jul 18, 2021
Merged
Fix WaitForConnectionAsync when NamedPipeServerStream is disposed #52825
stephentoub
merged 8 commits into
dotnet:main
from
manandre:dispose-shared-namedpipeserverstream
Jul 18, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagging subscribers to this area: @carlossanlop Issue DetailsFixes #40674 /cc @jaredpar @davidfowl
|
stephentoub
reviewed
May 26, 2021
src/libraries/System.IO.Pipes/tests/PipeStreamConformanceTests.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
May 26, 2021
src/libraries/System.IO.Pipes/tests/PipeStreamConformanceTests.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
May 26, 2021
src/libraries/System.IO.Pipes/tests/PipeStreamConformanceTests.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
May 26, 2021
src/libraries/System.IO.Pipes/tests/PipeStreamConformanceTests.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
May 26, 2021
stephentoub
reviewed
May 26, 2021
src/libraries/System.IO.Pipes/tests/PipeStreamConformanceTests.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
May 26, 2021
src/libraries/System.IO.Pipes/src/System/IO/Pipes/NamedPipeServerStream.Unix.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
May 26, 2021
manandre
force-pushed
the
dispose-shared-namedpipeserverstream
branch
from
May 26, 2021 18:46
b13a2c5
to
6e6e7bb
Compare
Co-authored-by: Stephen Toub <[email protected]>
manandre
force-pushed
the
dispose-shared-namedpipeserverstream
branch
from
June 1, 2021 22:09
6e6e7bb
to
ef60a2f
Compare
stephentoub
reviewed
Jul 18, 2021
src/libraries/System.IO.Pipes/src/System/IO/Pipes/NamedPipeServerStream.Unix.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.IO.Pipes/src/System/IO/Pipes/NamedPipeServerStream.Unix.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Jul 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40674
/cc @jaredpar @davidfowl