Delete an unnecessary pessimization for x86. #52803
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now if we have an incoming struct its fields can be enregistered on x86.
It includes both cases:
struct {int}
and the field is used from the reg.the regressions are from additional reg pressure + CSE, nothing stands up.
libraries diffs are very nice, hope some people are still using x86 :-)
I will do it for arm32 as well, this condition was breaking a struct contract that I need to satisfy for struct enreg, the contract is:
if struct's promotion type is 'DEPENDENT' the struct should be marked as 'doNotEnreg`.