Skip to content

Conversation

@ViktorHofer
Copy link
Member

During the migration from pkgproj to csproj, the <IsSourcePackage /> declaration was lost. Setting this again to auto-generate the expected build target.

cc @dougbu

During the migration from pkgproj to csproj, the `<IsSourcePackage />` declaration was lost. Setting this again to auto-generate the expected build target.
@ghost
Copy link

ghost commented May 10, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

During the migration from pkgproj to csproj, the <IsSourcePackage /> declaration was lost. Setting this again to auto-generate the expected build target.

cc @dougbu

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-Infrastructure-libraries

Milestone: -

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ViktorHofer
Copy link
Member Author

Failure is https://github.com/dotnet/core-eng/issues/13026. Merging to unblock official build ingestion in aspnetcore/extensions.

@ViktorHofer ViktorHofer merged commit 7e44013 into main May 10, 2021
@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-1 branch May 10, 2021 15:12
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants