Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark RNGCryptoServiceProvider as Obsolete #52373

Merged
merged 8 commits into from
May 8, 2021
Merged

Mark RNGCryptoServiceProvider as Obsolete #52373

merged 8 commits into from
May 8, 2021

Conversation

jeffhandley
Copy link
Member

Fixes #40169, marking RNGCryptoServiceProvider as obsolete, guiding usage toward RandomNumberGenerator.Create().

@jeffhandley jeffhandley added area-System.Security breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. labels May 6, 2021
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented May 6, 2021

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #40169, marking RNGCryptoServiceProvider as obsolete, guiding usage toward RandomNumberGenerator.Create().

Author: jeffhandley
Assignees: -
Labels:

area-System.Security, breaking-change
Milestone: -

@ghost ghost added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label May 6, 2021
@jeffhandley
Copy link
Member Author

The breaking change documentation will be covered by dotnet/docs#23856.

/cc @gewarren

@jeffhandley jeffhandley removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label May 6, 2021
@jeffhandley jeffhandley mentioned this pull request May 6, 2021
Closed
14 tasks
@jeffhandley
Copy link
Member Author

The failing check is #51584.

@GrabYourPitchforks
Copy link
Member

I think the System.Security.Principal.Windows test changes may have to be reverted, as that .csproj cross-targets core + full framework. But everything else LGTM.

@jeffhandley
Revert "Use RandomNumberGenerator.GetBytes() instead of RandomNumberG…
2665a3a 
…enerator.Create().GetBytes()"

This reverts commit 447f848.
@jeffhandley jeffhandley merged commit ebd695f into dotnet:main May 8, 2021
@jeffhandley jeffhandley deleted the jeffhandley/obsolete-rngcryptoserviceprovider branch May 8, 2021 01:33
@GrabYourPitchforks GrabYourPitchforks mentioned this pull request May 8, 2021
Merged
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bartonjs bartonjs bartonjs left review comments

@GrabYourPitchforks GrabYourPitchforks GrabYourPitchforks approved these changes

Assignees
No one assigned
Labels
area-System.Security breaking-change Issue or PR that represents a breaking API or functional change over a prerelease.
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

API proposal: Obsolete RNGCryptoServiceProvider
4 participants
@jeffhandley @GrabYourPitchforks @bartonjs @karelz