Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address feedback from STJ source-gen PR #51300 #52147

Merged
merged 2 commits into from
May 4, 2021
Merged

Address feedback from STJ source-gen PR #51300 #52147

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c7b5a6
Address feedback from STJ source-gen PR #51300
layomia Apr 30, 2021
cc32c5b
Address review feedback
layomia May 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/project/list-of-diagnostics.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,3 +108,5 @@ The diagnostic id values reserved for .NET Libraries analyzer warnings are `SYSL
| __`SYSLIB1027`__ | *_`SYSLIB1024`-`SYSLIB1029` reserved for logging._* |
| __`SYSLIB1028`__ | *_`SYSLIB1024`-`SYSLIB1029` reserved for logging._* |
| __`SYSLIB1029`__ | *_`SYSLIB1024`-`SYSLIB1029` reserved for logging._* |
| __`SYSLIB1030`__ | [System.Text.Json.SourceGeneration] Did not generate serialization metadata for type. |
| __`SYSLIB1031`__ | [System.Text.Json.SourceGeneration] Duplicate type name. |
layomia marked this conversation as resolved.
Show resolved Hide resolved
7 changes: 6 additions & 1 deletion ...untime/CompilerServices/IsExternalInit.cs → ...untime/CompilerServices/IsExternalInit.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,12 @@ namespace System.Runtime.CompilerServices
/// This class should not be used by developers in source code.
/// </summary>
[EditorBrowsable(EditorBrowsableState.Never)]
public static class IsExternalInit
#if SYSTEM_PRIVATE_CORELIB
public
#else
internal
#endif
static class IsExternalInit
{
}
}
9 changes: 0 additions & 9 deletions src/libraries/Microsoft.CSharp/tests/IsExternalInit.cs
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion src/libraries/Microsoft.CSharp/tests/Microsoft.CSharp.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
<DebuggerSupport Condition="'$(DebuggerSupport)' == '' and '$(TargetOS)' == 'Browser'">true</DebuggerSupport>
</PropertyGroup>
<ItemGroup>
<Compile Include="$(CommonPath)System\Runtime\CompilerServices\IsExternalInit.cs" Link="Common\System\Runtime\CompilerServices\IsExternalInit.cs" />
<Compile Include="AccessTests.cs" />
<Compile Include="ArrayHandling.cs" />
<Compile Include="AssignmentTests.cs" />
Expand All @@ -28,7 +29,6 @@
<Compile Include="IntegerBinaryOperationTests.cs" />
<Compile Include="IntegerUnaryOperationTests.cs" />
<Compile Include="IsEventTests.cs" />
<Compile Include="IsExternalInit.cs" />
<Compile Include="NamedArgumentTests.cs" />
<Compile Include="NullableEnumUnaryOperationTest.cs" />
<Compile Include="RuntimeBinderExceptionTests.cs" />
Expand Down
4 changes: 3 additions & 1 deletion src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -684,7 +684,6 @@
<Compile Include="$(MSBuildThisFileDirectory)System\Runtime\CompilerServices\IntrinsicAttribute.cs" />
<Compile Include="$(MSBuildThisFileDirectory)System\Runtime\CompilerServices\IsByRefLikeAttribute.cs" />
<Compile Include="$(MSBuildThisFileDirectory)System\Runtime\CompilerServices\IsConst.cs" />
<Compile Include="$(MSBuildThisFileDirectory)System\Runtime\CompilerServices\IsExternalInit.cs" />
<Compile Include="$(MSBuildThisFileDirectory)System\Runtime\CompilerServices\IsReadOnlyAttribute.cs" />
<Compile Include="$(MSBuildThisFileDirectory)System\Runtime\CompilerServices\IsVolatile.cs" />
<Compile Include="$(MSBuildThisFileDirectory)System\Runtime\CompilerServices\InterpolatedStringBuilder.cs" />
Expand Down Expand Up @@ -1165,6 +1164,9 @@
<Compile Include="$(CommonPath)System\Diagnostics\CodeAnalysis\ExcludeFromCodeCoverageAttribute.cs">
<Link>Common\System\Diagnostics\CodeAnalysis\ExcludeFromCodeCoverageAttribute.cs</Link>
</Compile>
<Compile Include="$(CommonPath)System\Runtime\CompilerServices\IsExternalInit.cs">
<Link>Common\System\Runtime\CompilerServices\IsExternalInit.cs</Link>
</Compile>
<Compile Include="$(CommonPath)System\Runtime\Versioning\NonVersionableAttribute.cs">
<Link>Common\System\Runtime\Versioning\NonVersionableAttribute.cs</Link>
</Compile>
Expand Down
10 changes: 0 additions & 10 deletions src/libraries/System.Text.Json/gen/IsExternalInit.cs
View file
Open in desktop

This file was deleted.

22 changes: 0 additions & 22 deletions src/libraries/System.Text.Json/gen/JsonSerializableSyntaxReceiver.cs
View file
Open in desktop

This file was deleted.

Loading