HTTP/3: Fix variable length encoding #51486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsI noticed two byte encoding is wrong. Usable bits is 14, not 16 - https://tools.ietf.org/html/draft-ietf-quic-transport-16#section-16 Also adds const field that aspnetcore will use to calculate header sizes.
|
jkotalik
approved these changes
Apr 19, 2021
|
Is it possible to add a regression test for this? |
halter73
approved these changes
Apr 19, 2021
This was referenced Apr 19, 2021
There are tests in aspnetcore that check this scenario. I've created an issue for adding proper unit tests for this type - #51519 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed two byte encoding is wrong. Usable bits is 14, not 16 - https://tools.ietf.org/html/draft-ietf-quic-transport-16#section-16
Also adds const field that aspnetcore will use to calculate header sizes.