Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude Microsoft.Extension.Logging.Generators from framework compilation #51445

Closed
wants to merge 1 commit into from

Conversation

trylek
Copy link
Member

@trylek trylek commented Apr 17, 2021

Exclude the assembly in R2RTest as it's not a framework
assembly. I have also deleted some pre-existing CG2-specific
exclusions that seem to be no longer needed.

Thanks

Tomas

Fixes: #51430

/cc @dotnet/crossgen-contrib

…tion

Exclude the assembly in R2RTest as it's not a framework
assembly. I have also deleted some pre-existing CG2-specific
exclusions that seem to be no longer needed.

Thanks

Tomas
@trylek trylek added this to the 6.0.0 milestone Apr 17, 2021
@trylek trylek requested a review from mangod9 April 17, 2021 19:03
@trylek trylek mentioned this pull request Apr 19, 2021
@ericstj
Copy link
Member

ericstj commented Apr 19, 2021

Same thing is going to happen with @layomia's #51300, which merged this morning.

Perhaps we should have a convention detection for source generators and exclude those from binplacing like we did here:

cc @safern @Anipik @ViktorHofer

@trylek
Copy link
Member Author

trylek commented Apr 19, 2021

Sounds good to me, not binplacing generators and other "compile-time files" in CORE_ROOT is certainly a cleaner solution than just blocking them out in Crossgen compilation especially as the exclusion list in R2RTest is only audited once in a while so it's prone to becoming stale; in fact I mostly intended the exclusion list in R2RTest as a last resort kind of thing that we used temporarily during Crossgen2 development when some assemblies were still failing the build; I think we should gradually stop using and potentially even remove this exclusion logic. After all, it's only affecting coreclr test builds, publishing the framework and other related tasks don't consult this list in any manner.

@mangod9
Copy link
Member

mangod9 commented May 18, 2021

@trylek believe this can be closed since the issue was resolved by not placing the generators in Core_Root.

@trylek
Copy link
Member Author

trylek commented May 18, 2021

Yes, that matches my understanding.

@trylek trylek closed this May 18, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 17, 2021
@trylek trylek deleted the LoggingGenerators branch January 10, 2022 19:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

R2R tests failing
3 participants