Enable tests for MacCatalyst x64 #51139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ARM64: 0 of 156 iOS-passing test suites pass What's wrong with arm64...... |
directhex
added a commit
to directhex/runtime
that referenced
this pull request
Apr 27, 2021
…yml way was good for desktop mono only
|
Restricting to x64 for now, due to arm64 JIT problems |
Some tests are gated on the idea that platforms are EITHER speed or size optimized (the latter would be things like iOS, the former would be things like desktop Windows). Mac Catalyst is following iOS behaviours, especially as we cannot JIT, which was causing some tests e.g. in System.Linq to take a LONG LONG LONG time to complete.
steveisok
changed the title
|
Failure is unrelated #52464 |
steveisok
approved these changes
May 8, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.